Repository navigation
fix(trace-viewer): harden snapshot rendering - #44177
Pavel Feldman (pavelfeldman) merged 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"2 failed 2 flaky23649 passed, 716 skipped Merge workflow run. |
🟢 Neither failure was caused by this PRHi, I'm the Playwright bot. I checked the failures in tests 1, run 44125356941 at Details and suggested fixThe PR changes snapshot rendering and its tests, not the JUnit reporter or the failing test. Pre-existing failure — not a flake
The test added in #44107 assumes forward slashes for The two tests marked flaky in the merged report passed on retry and are not failed tests. Checked the failures on Linux by the Playwright bot - agent run |
9c013a2
into
microsoft:main
## ✨ Highlights - **🗂️ Identify and resume your extension sessions** ([#496](#496)) — `playwright-cli attach --extension=chrome --session=docs-review --session-color=blue` labels the tab group with your session name instead of a truncated product name. Disconnected groups remain available to select on the next connection. Use `--no-tab-group` to leave your existing tab organization alone. ([microsoft/playwright#44047](microsoft/playwright#44047)) - **🧹 Close an agent's tabs when its work is done** — `playwright-cli -s=docs-review detach --close-tabs` closes that extension session's tabs before disconnecting. Plain `detach` still leaves the tabs open for later. ([microsoft/playwright#44084](microsoft/playwright#44084)) - **🖥️ Install stable Chrome on Linux ARM64** ([microsoft/playwright#43998](microsoft/playwright#43998)) — `playwright-cli install-browser chrome` now installs Google's ARM64 Debian package instead of rejecting the architecture. ([microsoft/playwright#44020](microsoft/playwright#44020)) ## 🐛 Fixes - `fix(server): do not reveal the endpoint path over HTTP` — attaching to a Playwright browser server with `--endpoint` now requires its full `ws://` or `wss://` endpoint, including the path; HTTP endpoint discovery has been removed. HTTP URLs for `--cdp` are unaffected. ([microsoft/playwright#44190](microsoft/playwright#44190)) - `fix(mcp): do not wait for busy pages longer than 10s when connecting over CDP` — a busy existing tab no longer blocks `playwright-cli attach --cdp=http://localhost:9222` indefinitely. Pages that cannot initialize within 10 seconds are made available later when they respond. ([microsoft/playwright#44052](microsoft/playwright#44052), [microsoft/playwright#44105](microsoft/playwright#44105)) - `fix(cli): suggest matching ffmpeg installer for video recording` — when `video-start` needs ffmpeg, its error now recommends `playwright-cli install-browser ffmpeg`, which installs the revision used by the CLI. ([#540](#540), [microsoft/playwright#44088](microsoft/playwright#44088)) - `fix(mcp): validate run-code input` — `playwright-cli run-code` without code or `--filename` reports a clear input error instead of an internal `TypeError`. ([microsoft/playwright#44080](microsoft/playwright#44080), [microsoft/playwright#44087](microsoft/playwright#44087)) - `fix(locator): select among visible elements in first/last/nth with locateOnlyVisible` — with `browser.contextOptions.locateOnlyVisible` enabled, locators used in `run-code` apply `first()`, `last()` and `nth()` to visible matches instead of selecting a hidden element and finding nothing. Explicit visibility filters still take precedence. ([microsoft/playwright#43855](microsoft/playwright#43855), [microsoft/playwright#44083](microsoft/playwright#44083)) - `fix(chromium): apply timezone to service workers` — Chromium service workers honor `browser.contextOptions.timezoneId` from their first statement, keeping date handling consistent with pages. ([microsoft/playwright#43983](microsoft/playwright#43983), [microsoft/playwright#44021](microsoft/playwright#44021)) - `fix(tracing): hold dropped screencast frames while throttling` — recording with `playwright-cli tracing-start` uses less browser CPU on idle animated pages without changing the frames kept in the trace. ([microsoft/playwright#44053](microsoft/playwright#44053), [microsoft/playwright#44068](microsoft/playwright#44068)) - `fix(trace-viewer): harden snapshot rendering` — Trace Viewer blocks navigation and form submission from recorded snapshots. Trace-file routes also reject frame navigations, and its server checks WebSocket origins. ([microsoft/playwright#44177](microsoft/playwright#44177), [microsoft/playwright#44178](microsoft/playwright#44178)) ## 📦 Upgrading Node.js 20 or newer is required. ```bash npm install -g @playwright/cli@0.1.25 ``` Co-authored-by: microsoft-playwright-automation[bot] <203992400+microsoft-playwright-automation[bot]@users.noreply.github.com>
Summary
clickandauxclickonaandareawith one listener that it installs first, and ignores invalid custom element names.shadowrootmode/shadowrootontemplate.form-action 'none'.