Skip to content

feat(webkit): roll to r2395 - #44165

Merged
Devin Rousso (dcrousso) merged 1 commit into
mainfrom
roll-into-pw-webkit/2395
Nov 17, 2026
Merged

Devin Rousso (dcrousso) merged 1 commit into
mainfrom
roll-into-pw-webkit/2395

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/312f13d5a0a9472341b8bc744847fc815131e2cc. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chrome] › mcp/crash.spec.ts:31 › crash recovery › reports the navigation error, then resets and logs the crash @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:58 › crash recovery › lists only one tab @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:79 › crash recovery › marks non-current crashed tab in the tab list @mcp-ubuntu-latest-chrome

5237 passed, 633 skipped


Merge workflow run.

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor Author

🟢 All three failures predate this PR

Hi, I'm the Playwright bot. I checked the failed MCP run; the same three Chrome tests already fail on main.

Details

Covers MCP run 44019742853 at 12c89c4740447b93c946a21617e4f6f9b898f239.

The PR only updates WebKit from r2394 to r2395 and adds an optional WebKit protocol field. Neither change affects these Chrome-only crash-recovery tests.

Pre-existing flake / infra

All three failures also occur in the earlier main job at 354e6fa33a899f8e0ee1ef5428eaf9a934378615, with the same errors and failing lines:

  • [chrome] mcp/crash.spec.ts:31 — reports the navigation error, then resets and logs the crash: 30-second timeout in the recovery check at line 48.
  • [chrome] mcp/crash.spec.ts:58 — lists only one tab: 30-second timeout and Not connected at the browser_tabs call, line 71.
  • [chrome] mcp/crash.spec.ts:79 — marks non-current crashed tab in the tab list: 30-second timeout and Not connected at the browser_tabs call, line 93.

These are confirmed pre-existing failures, not regressions from this PR. This comparison does not establish whether they are intermittent or consistently broken.

Checked the failures on Linux by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › reporter-junit.spec.ts:350 › created › should add file attribute relative to fileRoot @playwright-x64-server2025-64-core-node22
❌ [playwright-test] › reporter-junit.spec.ts:350 › merged › should add file attribute relative to fileRoot @playwright-x64-server2025-64-core-node22

23648 passed, 716 skipped


Merge workflow run.

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor Author

🟢 Both JUnit failures predate this PR

Hi, I'm the Playwright bot. Both failures also occur on main; this WebKit roll did not cause them.

Details

Covers tests 1 run 44019742801 at 12c89c4740447b93c946a21617e4f6f9b898f239.

Pre-existing failures

[playwright-test] reporter-junit.spec.ts:350 › should add file attribute relative to fileRoot fails in both created and merged modes on Windows. Both fail at line 374: expected classname="auth/a.test.js", received classname="auth\a.test.js".

The same two tests fail at the same assertion in the earlier main job, at 354e6fa33a899f8e0ee1ef5428eaf9a934378615. This confirms a pre-existing Windows test defect, not an intermittent flake.

The PR only updates WebKit r2394 to r2395 and adds an optional WebKit protocol field. Neither change affects the JUnit reporter.

The small follow-up fix is to expect path.join('auth', 'a.test.js') for classname. Keep the file expectation as src/auth/a.test.js: the reporter explicitly normalizes that attribute to forward slashes.

The MCP report already has a separate verdict.

Checked the failures on Linux - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

2 fatal errors, not part of any test
4 failed
❌ [chromium-page] › page/page-event-pageerror.spec.ts:289 › ER-022 should not fire for a caught fetch rejected by a pending navigation @frozen-time-library-chromium-linux
❌ [chromium-page] › page/page-event-pageerror.spec.ts:289 › ER-022 should not fire for a caught fetch rejected by a pending navigation @realtime-time-library-chromium-linux
❌ [webkit-page] › page/page-leaks.spec.ts:136 › LE-003 expect should not leak @webkit-playwright-x64-server2025-64-core
❌ [webkit-page] › page/workers.spec.ts:53 › WO-003 should reject in-flight evaluate and emit close when page closes @webkit-playwright-x64-server2025-64-core

11 flaky ⚠️ [chromium-library] › library/beforeunload.spec.ts:20 › BU-001 should close browser with beforeunload page `@chromium-macos-15-large`
⚠️ [chromium-library] › library/browsercontext-basic.spec.ts:36 › BC-002 should be able to click across browser contexts `@chromium-macos-15-large`
⚠️ [chromium-library] › library/tracing.spec.ts:604 › TR-023 should produce screencast frames crop `@chromium-macos-15-large`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › BU-009 should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node26`
⚠️ [chromium-library] › library/video.spec.ts:113 › screencast › VI-003 should capture static page `@chrome-macos-latest`
⚠️ [installation tests] › connect-to-selenium.spec.ts:20 › connect to selenium `@package-installations-ubuntu-latest-node24`
⚠️ [firefox-page] › page/page-filechooser.spec.ts:305 › FC-020 should be able to reset selected files with empty file list `@tracing-firefox`
⚠️ [webkit-library] › library/heap.spec.ts:304 › LE-014 cycle handles `@webkit-playwright-x64-server2025-64-core`
⚠️ [webkit-page] › page/wheel.spec.ts:135 › MO-021 should set the modifiers `@webkit-macos-15-xlarge`
⚠️ [webkit-page] › page/workers.spec.ts:53 › WO-003 should reject in-flight evaluate and emit close when page closes `@webkit-macos-15-xlarge`
⚠️ [webkit-page] › page/locator-query.spec.ts:304 › LO-182 count() should not throw during navigation `@webkit-macos-15-large`

127251 passed, 4110 skipped, 7 did not run


Merge workflow run.

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor Author

🟡 WebKit leak failure remains uncertain

Hi, I'm the Playwright bot. Two failure groups already occur on main, but I could not clear the WebKit leak failure or identify the Chrome Beta suite hang.

Details

Covers tests 2 run 44019743102 at 12c89c4740447b93c946a21617e4f6f9b898f239: four failed test entries and two fatal errors. The PR updates WebKit r2394 → r2395 and adds an optional protocol field; the Chromium jobs do not use the changed browser.

Pre-existing flake / infra

  • Chromium page/page-event-pageerror.spec.ts:289, ER-022, frozen and realtime: both already time out waiting for pageerror at line 310 in the earlier main frozen job and realtime job, at 354e6fa33a899f8e0ee1ef5428eaf9a934378615. The test uses the replaced setTimeout: the frozen clock does not advance, and the realtime clock catches the thrown error. Proposed small fix: use window.builtins.setTimeout, as neighboring error tests do.
  • WebKit page/workers.spec.ts:53, WO-003, Windows: the earlier main job fails at the same line 65 assertion, receiving “Execution context was destroyed” instead of “Target page, context or browser has been closed”. This failure predates r2395.

These are confirmed pre-existing failures; that does not establish that they are intermittent.

Uncertain

  • WebKit page/page-leaks.spec.ts:136, LE-003, Windows job: all four attempts retain 58 weak-reference entries where fewer than 25 are expected. I found no earlier failure of this same test in the inspected logs. A different leak test, LE-002, flakes on earlier main, but that is not proof for LE-003. The browser roll could affect collection; a Windows comparison of this test on r2394 and r2395 is needed. Raising the threshold would hide the failure, not explain it.
  • Two fatal errors, Chrome Beta job: the suite and its teardown each hit the 7200-second limit, leaving seven tests unrun. These are suite-level timeouts, not two additional failed tests. The job installs only Chrome Beta, so there is no evident link to the WebKit roll, but the log does not identify the hung operation or establish a prior occurrence.

No PR code was built or run. The upstream browser-build commit was not accessible with the available read token, so I could not inspect its implementation changes.

Checked the failures on Linux by the Playwright bot - agent run

@dcrousso
Devin Rousso (dcrousso) merged commit 765383d into main Nov 17, 2026
56 of 62 checks passed
@dcrousso
Devin Rousso (dcrousso) deleted the roll-into-pw-webkit/2395 branch November 17, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant