Skip to content

devops: pin exact Node.js version in Docker images - #44156

Merged
Pavel Feldman (pavelfeldman) merged 2 commits into
microsoft:mainfrom
yury-s:pin-node-version
Nov 17, 2026
Merged

Pavel Feldman (pavelfeldman) merged 2 commits into
microsoft:mainfrom
yury-s:pin-node-version

Conversation

@yury-s

@yury-s Yury Semikhatsky (yury-s) commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Each Dockerfile pins the exact Node.js version (ARG NODE_VERSION=26.13.1), not only the major version.
  • Docker images install that version from nodejs.org/dist (with a checksum check) and no longer use NodeSource. Node.js moves from /usr/bin to /usr/local/bin.
  • update-playwright-node.mjs now rolls the full version.

The version lives in the playwright-core package.json as
playwright.nodeVersion. Docker images install that exact version
from nodejs.org instead of the latest NodeSource build of a major.
@github-actions

This comment has been minimized.

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

🟢 Both failures already occur on main

Hi, I'm the Playwright bot. I checked the failed run: neither failure was caused by this PR.

Details

The PR changes Docker Node.js installation and version metadata, not the JUnit reporter or these tests. The failed Windows job still uses Node.js 22 through actions/setup-node.

Pre-existing failure

  • reporter-junit.spec.ts:350 › should add file attribute relative to fileRoot, both created and merged, fails at the classname assertion: expected auth/a.test.js, received auth\a.test.js. Both variants have the identical error on main run 43957125418, commit 826ce42b8664ea940424e77ce51f1cdf96dcd37f, before this PR's run. This is a Windows path assertion bug, not evidence of an intermittent flake.
  • The test was added in feat(junit): add addFileAttribute and fileRoot options #44107. A small test-only fix is to expect path.join('auth', 'a.test.js') for classname; the separate file assertions should retain forward slashes.

Checked the failures on Linux by the Playwright bot - agent run

@github-actions

This comment has been minimized.

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

🟢 All three MCP failures already occur on main

Hi, I'm the Playwright bot. I checked the failed MCP run: these failures were not caused by this PR.

Details

The PR changes Docker Node.js installation and version metadata. The failed Ubuntu Chrome job uses actions/setup-node with Node.js 22 and runs directly under xvfb; it does not use the changed Dockerfiles.

Pre-existing failures

All three [chrome] › mcp/crash.spec.ts › crash recovery tests fail identically in main run 43957125480, commit 826ce42b8664ea940424e77ce51f1cdf96dcd37f, before this PR's run:

  • :31 › reports the navigation error, then resets and logs the crash — 30-second timeout in the recovery check at line 48.
  • :58 › lists only one tab — 30-second timeout and Not connected at the browser_tabs call on line 71.
  • :79 › marks non-current crashed tab in the tab list — the same timeout and Not connected at line 93.

This confirms pre-existing crash-recovery failures, not that they are intermittent flakes. The earlier JUnit failures already have a separate verdict above.

Checked the failures on Linux by the Playwright bot - agent run

Remove playwright.nodeVersion from the playwright-core package.json.
The roll script writes the exact version into the Dockerfiles.
@yury-s Yury Semikhatsky (yury-s) changed the title devops: pin exact Node.js version for Docker and language ports devops: pin exact Node.js version in Docker images Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chrome] › mcp/crash.spec.ts:31 › crash recovery › reports the navigation error, then resets and logs the crash @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:58 › crash recovery › lists only one tab @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:79 › crash recovery › marks non-current crashed tab in the tab list @mcp-ubuntu-latest-chrome

5232 passed, 631 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › reporter-junit.spec.ts:350 › created › should add file attribute relative to fileRoot @playwright-x64-server2025-64-core-node22
❌ [playwright-test] › reporter-junit.spec.ts:350 › merged › should add file attribute relative to fileRoot @playwright-x64-server2025-64-core-node22

1 flaky ⚠️ [installation tests] › connect-to-selenium.spec.ts:20 › connect to selenium `@package-installations-ubuntu-latest`

23643 passed, 716 skipped


Merge workflow run.

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

🟢 All five failures already occur on main

Hi, I'm the Playwright bot. I checked MCP run 43971153260 and tests 1 run 43971153371 at 8c11fa6: none of their failures was caused by this PR.

Details

The PR changes only three Dockerfiles and the Node.js roll script. Both failed jobs use Node.js 22 through actions/setup-node, without the changed Dockerfiles.

Pre-existing failures

All three Ubuntu Chrome crash-recovery tests fail identically in main run 43957125480, commit 826ce42b8664ea940424e77ce51f1cdf96dcd37f, before this PR's run:

  • mcp/crash.spec.ts:31 › reports the navigation error, then resets and logs the crash — 30-second timeout in the recovery check at line 48.
  • mcp/crash.spec.ts:58 › lists only one tab — 30-second timeout and Not connected at the browser_tabs call on line 71.
  • mcp/crash.spec.ts:79 › marks non-current crashed tab in the tab list — the same timeout and Not connected at line 93.

The Windows JUnit failure also repeats at this head:

  • reporter-junit.spec.ts:350 › should add file attribute relative to fileRoot, both created and merged — expected auth/a.test.js, received auth\a.test.js at the classname assertion. Both variants fail identically in main run 43957125418, on the same main commit. A small test-only fix is to expect path.join('auth', 'a.test.js') for classname; retain forward slashes in the separate file assertions.

These are confirmed pre-existing failures; the evidence does not establish that they are intermittent flakes.

Checked the failures on Linux by the Playwright bot - agent run

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

🟢 Both failures are pre-existing, not caused by this PR

Hi, I'm the Playwright bot. I checked tests 1 run 43971153371 at 8c11fa6; this repeats the earlier verdict for the same run.

Details

The only failed job is Windows Test Runner, using Node.js 22 through actions/setup-node. It does not use the three Dockerfiles or the Node.js roll script changed here.

Pre-existing failures

reporter-junit.spec.ts:350 › should add file attribute relative to fileRoot, both created and merged: the earlier investigation confirmed the identical Windows path mismatch on main run 43957125418, commit 826ce42b8664ea940424e77ce51f1cdf96dcd37f, before this PR's run. The classname assertion expects auth/a.test.js but receives auth\a.test.js. Use path.join('auth', 'a.test.js') for that assertion; keep forward slashes in the separate file assertions.

These are pre-existing test failures, not established intermittent flakes. The Selenium test passed on retry and is not an outstanding failure.

This pass verified the diff, workflow configuration and failed-job identity. Fresh log access was blocked by GitHub tool errors and REST permission checks; the exact error comparison above comes from the earlier investigation.

Checked the failures on Linux by the Playwright bot - agent run

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 1aa8478 into microsoft:main Nov 17, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants