Skip to content

feat(html-reporter): add Blink mode for image mismatches - #44131

Merged
Devin Rousso (dcrousso) merged 2 commits into
microsoft:mainfrom
bhanutejaindla:feat/html-reporter-image-blink
Nov 17, 2026
Merged

Devin Rousso (dcrousso) merged 2 commits into
microsoft:mainfrom
bhanutejaindla:feat/html-reporter-image-blink

Conversation

@bhanutejaindla

@bhanutejaindla BhanuTeja Indla (bhanutejaindla) commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Add a 500 ms toggle between actual and expected images in image mismatch views.
blink-mode-recording.webm

Fixes: #44126

Add a 500 ms toggle between actual and expected images in image mismatch views.

Fixes: microsoft#44126

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dcrousso

Copy link
Copy Markdown
Contributor

could you please upload a screen recording of what this change looks like? i have a suspicion that 500ms may be too fast but id like to see it before deciding

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@bhanutejaindla

Copy link
Copy Markdown
Contributor Author

I have attached the recording, could you please review it?

{modeTab('expected', expectedImageTitle)}
{modeTab('sxs', 'Side by side')}
{modeTab('slider', 'Slider')}
{enableBlink && modeTab('blink', 'Blink')}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this would be just another option without any "special" treatment which requires a dedicated Boolean parameter such as "enableBlink". I assume the justification is that this is a "new" thing, separate from the current other view options, and so you wish to wrap it in a feature-flag of some sort.

@yairEO

Copy link
Copy Markdown

could you please upload a screen recording of what this change looks like? i have a suspicion that 500ms may be too fast but id like to see it before deciding

My workplace internal tool has been using 500ms for blinking in our internal playwright screenshot comparison tool, as I've stated in the original issue I've opened and it works great. This tool has been in constant internal use for over 6 months by several senior devs.

@bhanutejaindla

Copy link
Copy Markdown
Contributor Author

Thanks, that’s helpful. I’ve attached a recording so you can judge the 500 ms timing. Does that address your concern? I also saw your suggestion about avoiding the enableBlink flag. Would you prefer Blink to be available wherever ImageDiffView is used, or limited to these report views? Please let me know if there are other changes you’d like before approval

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bhanutejaindla

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback. I removed enableBlink and made Blink a standard mode, available wherever ImageDiffView is used. I kept the interval at 500 ms; I’ve attached a recording so you can review how it looks. Does this address your concern?

@bhanutejaindla

Copy link
Copy Markdown
Contributor Author

Hi, I pushed a follow-up commit (134738f) to address the review feedback. The CI workflows for the latest commit are marked action required and haven’t started. Could a maintainer approve and run them? Thanks!

@yairEO

Copy link
Copy Markdown

Where is the attached recording? I don't see it in the PR description nor in the changed files

@bhanutejaindla

BhanuTeja Indla (bhanutejaindla) commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor Author

Yair Even Or (@yairEO) , I removed enableBlink and made Blink a standard mode. I’ve attached the recording here; the 500 ms timing is unchanged. Please let me know if you’d like any other changes.
blink-mode-recording.webm

@bhanutejaindla

Copy link
Copy Markdown
Contributor Author

Thanks for the reaction! Just checking whether the update addresses your feedback. Please let me know if you’d like any further changes.

@yairEO

Yair Even Or (yairEO) commented Nov 17, 2026 •

Copy link
Copy Markdown

Thanks for the reaction! Just checking whether the update addresses your feedback. Please let me know if you’d like any further changes.

It's good, thanks a lot! I'm not working here so I cannot approve this PR.

I would place the video recording in the description so it won't get lost in the comments, as it's important

@bhanutejaindla

Copy link
Copy Markdown
Contributor Author

Devin Rousso (@dcrousso) , could you please review the changes . Please let me know if you’d like any further changes.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chrome] › mcp/crash.spec.ts:31 › crash recovery › reports the navigation error, then resets and logs the crash @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:58 › crash recovery › lists only one tab @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:79 › crash recovery › marks non-current crashed tab in the tab list @mcp-ubuntu-latest-chrome

5237 passed, 633 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › reporter-junit.spec.ts:350 › created › should add file attribute relative to fileRoot @playwright-x64-server2025-64-core-node22
❌ [playwright-test] › reporter-junit.spec.ts:350 › merged › should add file attribute relative to fileRoot @playwright-x64-server2025-64-core-node22

3 flaky ⚠️ [installation tests] › connect-to-selenium.spec.ts:20 › connect to selenium `@package-installations-ubuntu-latest`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@chromium-playwright-x64-ubuntu24-64-core-node22`
⚠️ [webkit-page] › page/workers.spec.ts:53 › WO-003 should reject in-flight evaluate and emit close when page closes `@webkit-playwright-x64-ubuntu24-64-core-node22`

23645 passed, 716 skipped


Merge workflow run.

@dcrousso
Devin Rousso (dcrousso) merged commit 75e1e71 into microsoft:main Nov 17, 2026
34 of 36 checks passed
@bhanutejaindla
BhanuTeja Indla (bhanutejaindla) deleted the feat/html-reporter-image-blink branch November 17, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add "blink" option inside "Image mismatch" section of HTML report

4 participants