Skip to content

chore: allow new versions that fix high or critical advisories in check-dependency-age - #44110

Merged
Yury Semikhatsky (yury-s) merged 4 commits into
microsoft:mainfrom
yury-s:dependency-age-fix-hint
Nov 13, 2026
Merged

Yury Semikhatsky (yury-s) merged 4 commits into
microsoft:mainfrom
yury-s:dependency-age-fix-hint

Conversation

@yury-s

@yury-s Yury Semikhatsky (yury-s) commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary

  • A version in package-lock.json that is less than 7 days old now passes when it fixes an advisory of high or critical severity, and no version that is at least 7 days old fixes it.
  • Fixes of moderate and low severity still fail and must wait.
  • For each version that is too new, the check prints the advisories that it fixes with their severity, and the oldest version that fixes them with its age.

Example for the lock file from #44100, which still fails:

node_modules/hono@4.13.18 was published on 2026-11-11, less than 7 days ago.
  Version 4.13.16, published on 2026-11-01, 12 days ago, is the oldest one that fixes:
    GHSA-4m76-xfj5-7975 (moderate)
    GHSA-h7mg-cq63-vhpq (moderate)
    GHSA-3gg2-335m-rxc6 (low)
    GHSA-46wx-v44x-9hh2 (moderate)
    GHSA-4h7h-rv7c-7m2v (moderate)

@yury-s Yury Semikhatsky (yury-s) changed the title chore: print the oldest fixed version in check-dependency-age chore: allow new versions that fix high or critical advisories in check-dependency-age Nov 13, 2026
@github-actions

This comment has been minimized.

@yury-s
Yury Semikhatsky (yury-s) merged commit c359de0 into microsoft:main Nov 13, 2026
23 of 24 checks passed
@yury-s
Yury Semikhatsky (yury-s) deleted the dependency-age-fix-hint branch November 13, 2026 22:49
@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

🟢 The reported failure is a pre-existing flake

I'm the Playwright bot. I checked the failure against the PR changes and test history.

Details

Covers tests 1, run 43520341306, for PR revision e2de88cb747d. That revision changes only utils/check_dependency_age.js; it does not change video recording, tracing, tests, or dependency versions.

Pre-existing flake / infra

  • [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace — the trace contains no screencast-frame, so frame.file throws on all four attempts. The same test, on the same Ubuntu/Node 22 configuration, had the identical error on main at 0ad21f1d34e4 in run 43479847550: failed twice, then passed. It also failed all four attempts on main at dbcf1194a797 in run 43466659084.

The popup test passed on retry, so it is not a failure group. The triggering run was cancelled; this verdict covers the reported results, not the missing results or the newer PR revision.

Checked the failures on Linux by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

23638 passed, 716 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chrome] › mcp/crash.spec.ts:31 › crash recovery › reports the navigation error, then resets and logs the crash @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:58 › crash recovery › lists only one tab @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:79 › crash recovery › marks non-current crashed tab in the tab list @mcp-ubuntu-latest-chrome

5232 passed, 631 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants