Repository navigation
docs(test): fix page.screenshot() call in TestInfo example - #44049
Merged
Yury Semikhatsky (yury-s) merged 1 commit intoNov 11, 2026
Merged
Yury Semikhatsky (yury-s) merged 1 commit into
Yury Semikhatsky (yury-s) merged 1 commit into
Conversation
page.screenshot() takes an options object, so the path has to be passed as `path`. With a string argument the screenshot is not saved.
Contributor
Author
|
@microsoft-github-policy-service agree |
Yury Semikhatsky (yury-s)
approved these changes
Nov 11, 2026
Contributor
Test results for "MCP"5229 passed, 637 skipped Merge workflow run. |
Contributor
Test results for "tests 1"2 flaky23617 passed, 713 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestInfoexample callspage.screenshot(testInfo.outputPath('screenshot.png')), butpage.screenshot()takes an options object. In TypeScript the example does not compile (TS2559: Type 'string' has no properties in common with type 'PageScreenshotOptions'). In JavaScript the test passes, butscreenshot.pngis not written.{ path: testInfo.outputPath('screenshot.png') }and regeneratepackages/playwright/types/test.d.ts.