Skip to content

fix(screenshot): preserve scroll-driven animation progress - #44022

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
mainfrom
triage/43986/42721656152-1
Nov 10, 2026
Merged

Yury Semikhatsky (yury-s) merged 1 commit into
mainfrom
triage/43986/42721656152-1

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Leave scroll- and view-driven animations unchanged when screenshots disable animations. Firefox reports a finite numeric end time and finishes these animations; Chromium and WebKit report a percentage end time and cancel them instead.

The regression waits for the scroll timeline to settle before comparing screenshots and checks that a later screenshot keeps the original appearance. It needs a separate setup: existing SS-052 through SS-063 use time-driven rotation/transition fixtures or frozen playback rates, not a scroll container and its dependent animation.

Build and flint pass. The regression passes on Chromium, Firefox and WebKit (nine final repeated cases). The screenshot suites have 265 passes, three skips and two Firefox WebGL failures, both also verified without the fix.

Fixes #43986

Triaged on Linux by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 flaky ⚠️ [webkit-library] › library/trace-viewer.spec.ts:616 › TV-029 should show font preview `@webkit-playwright-x64-ubuntu24-64-core-node22`

23620 passed, 705 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [webkit] › mcp/sse.spec.ts:196 › sse transport browser lifecycle (persistent) @mcp-ubuntu-latest-webkit

5228 passed, 637 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 CI failure is a pre-existing flake

Hi, I'm the Playwright bot. I checked the CI reports, PR changes, and refreshed test history.

Details

No CI failure appears caused by this PR. Its product change only affects animation handling during screenshots with animations: 'disabled'; the failing SSE test checks storage persistence and does not take screenshots.

Pre-existing flakes

  • [webkit] › mcp/sse.spec.ts:196 › sse transport browser lifecycle (persistent) — fails here because localStorage.a returns undefined instead of "42" after reconnecting. The same test, browser, Linux bot, and error occurred on main, commit df1ca47b1eb9, in run 42667940510, before this PR existed. The refreshed database records 12 failed and 737 passed runs for this test on that bot, excluding this PR.

  • [webkit-library] › library/trace-viewer.spec.ts:616 › TV-029 should show font preview — passed on retry, so it is not an outstanding failure. The same “Response body is not available for this request” error also occurred and passed on retry in feat(test runner): resolve package.json imports like TypeScript #44010, run 42699977926.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: animations: "disabled" finishes scroll-driven animations in screenshots

1 participant