Skip to content

chore(deps): lint that lock file versions are at least 7 days old - #43944

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:check-dependency-age
Nov 5, 2026
Merged

Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:check-dependency-age

Conversation

@pavelfeldman

Copy link
Copy Markdown
Member

Summary

  • Adds utils/check_dependency_age.js to npm run lint and npm run flint. It fails when any version in package-lock.json was published less than 7 days ago, or is not from the npm registry.
  • The audit-deps skill keeps picking versions that are at least 8 days old, so its rolls pass the lint.

Adds utils/check_dependency_age.js, run by npm run lint and npm run flint.
It fails when package-lock.json resolves any package to a version that was
published less than 7 days ago, or to a package that is not from the npm
registry. The playwright-audit-deps skill keeps rolling to versions that are
at least 8 days old, so its output passes the lint.
@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 7565d47 into microsoft:main Nov 5, 2026
22 of 24 checks passed
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [webkit] › mcp/http.spec.ts:92 › http transport browser lifecycle (isolated) @mcp-ubuntu-latest-webkit
❌ [webkit] › mcp/sse.spec.ts:196 › sse transport browser lifecycle (persistent) @mcp-ubuntu-latest-webkit

5192 passed, 616 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🟢 Both failures are pre-existing flakes

Hi, I'm the Playwright bot. I compared the two failures with this PR and their CI history; neither looks caused by this PR.

Details

The latest MCP report lists two WebKit failures on Ubuntu. This PR adds a dependency-age lint check and updates contributor instructions. It changes no dependency versions, MCP code, browser code, or tests. The MCP job does not run the new lint check.

Pre-existing flakes

  • [webkit] › mcp/http.spec.ts:92 › http transport browser lifecycle (isolated) — timed out after 30 seconds. The same test had the same timeout on main, SHA 8a56dd3a2c90, on November 3 (run). Before this PR's run, it failed in 13 of 760 runs, passing the other 747.
  • [webkit] › mcp/sse.spec.ts:196 › sse transport browser lifecycle (persistent) — expected saved localStorage.a to return "42", but got undefined. The same test failed with that exact mismatch on main, SHA 12ade829b4ed, on October 14 (run). Before this PR's run, it failed in 10 of 760 runs, passing the other 750.

Counts are from the refreshed test-results database, October 9–November 5, for these exact tests in the webkit project on mcp-ubuntu-latest-webkit, excluding this PR. Each count uses the final result after retries.

Triaged by the Playwright bot - agent run

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

Warning

The triggering workflow run ended with status cancelled. Results below may be incomplete — blob reports from cancelled or timed-out shards are missing, so passing/failing counts do not reflect the full test suite.

1 flaky ⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@chromium-playwright-x64-ubuntu24-64-core-node22`

23533 passed, 705 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants