Repository navigation
test(android): skip NA-051 and report a missing device clearly - #43896
Merged
Dmitry Gozman (dgozman) merged 1 commit intoNov 4, 2026
Merged
Conversation
Service workers need a secure context, but the Android test server is reached over http://10.0.2.2, so NA-051 fails on every Android run since it was rewritten to use a service worker. Skip it there, like Electron. When the emulator has died, every Android test failed with "Cannot read properties of undefined (reading 'shell')". Throw a clear error from the worker fixture instead.
Contributor
Test results for "tests 1"1 flaky23585 passed, 704 skipped Merge workflow run. |
Contributor
Test results for "MCP"5194 passed, 616 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
approved these changes
Nov 4, 2026
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NA-051 should be able to navigate to a page controlled by service workeron Android: service workers need a secure context, but the Android test server is reached overhttp://10.0.2.2. The test has failed on every Android run since test(webkit): cover IndexedDB after service-worker cross-site navigation #43755 rewrote it around a service worker.Cannot read properties of undefined (reading 'shell')when the emulator has died.