Repository navigation
chore(mcp): fold the v2 relay handler into the relay and BrowserModel - #43893
Merged
Yury Semikhatsky (yury-s) merged 2 commits intoNov 5, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Pavel Feldman (pavelfeldman)
left a comment
Member
There was a problem hiding this comment.
Could you add a diagram of explanation on the roles of these components? I don't understand the clear responsibilities of each of the parts.
Member
Author
Added to the comment in cdpRelay.ts. |
Contributor
Test results for "MCP"5194 passed, 616 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
approved these changes
Nov 5, 2026
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdpRelayV2.ts;CDPRelayServeris now pure transport (two sockets, the handshake wait, CDP framing).BrowserModelowns the extension connection and both translation directions: the CDP command switch and the extension event switch. A new relay→extension command is oneExtensionCommandsentry plus one model method.V2suffix from protocol types and add a typedExtensionEventunion so the event switch has no casts.Pure refactoring, no behavior changes.