Skip to content

feat(webkit): roll to r2388 - #43866

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
roll-into-pw-webkit/2388
Nov 2, 2026
Merged

Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
roll-into-pw-webkit/2388

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/7dbb25ce8c24e64c11a4fe1aa740233961ab7fe1. Build has full platform coverage - check that all tests pass there.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 flaky ⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@chromium-playwright-x64-ubuntu24-64-core-node22`

23587 passed, 705 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5194 passed, 616 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

1 failed
❌ [android-page] › page/page-goto.spec.ts:695 › NA-051 should be able to navigate to a page controlled by service worker

12 flaky ⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:178 › CG-155 should work with --save-har `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/beforeunload.spec.ts:20 › BU-001 should close browser with beforeunload page `@chromium-macos-15-large`
⚠️ [chromium-library] › library/browsercontext-basic.spec.ts:36 › BC-002 should be able to click across browser contexts `@chromium-macos-15-large`
⚠️ [chromium-library] › library/browsercontext-csp.spec.ts:115 › CS-005 should not crash on javascript: navigation `@chromium-macos-15-large`
⚠️ [chromium-library] › library/browsercontext-device.spec.ts:33 › device › DV-002 should support clicking `@chromium-macos-15-large`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:80 › CD-003 should connect when the opener of an existing page has no renderer `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:117 › CD-004 should connect when an existing page has been discarded `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › BU-009 should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1937 › TV-087 should not leak recorders `@chrome-macos-latest`
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:87 › CG-100 should update aria snapshot highlight `@firefox-macos-15-large`
⚠️ [webkit-library] › library/heap.spec.ts:304 › LE-014 cycle handles `@webkit-playwright-x64-server2025-64-core`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1937 › TV-087 should not leak recorders `@webkit-macos-15-large`

126865 passed, 4088 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🟢 The CI failure is pre-existing, not caused by this PR

Hi, I'm the Playwright bot. I checked the merged reports, failure logs, PR diff, and refreshed CI test history.

Details

This PR only changes the WebKit revision from 2387 to 2388. The only failed test runs against Chrome on Android, which does not use that binary. All WebKit jobs passed.

Pre-existing Android failure

[android-page] › page/page-goto.spec.ts:695 › NA-051 should be able to navigate to a page controlled by service worker fails on the initial attempt and retry because navigator.serviceWorker is undefined: Cannot read properties of undefined (reading 'controller'). See the failed Android job.

The refreshed results database shows the exact same test, project, and error on earlier main commits, also failing after retry:

This is a confirmed pre-existing failure, not merely an assumed flake. The other reported flaky tests passed on retry and left no additional failures.

Triaged by the Playwright bot - agent run

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 24cbcbf into main Nov 2, 2026
63 of 64 checks passed
@pavelfeldman
Pavel Feldman (pavelfeldman) deleted the roll-into-pw-webkit/2388 branch November 2, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant