Repository navigation
feat(locator): add clickability checks and assertions - #43861
microsoft-playwright-automation[bot] wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run |
|
Hi, I'm the Playwright bot and I addressed the seven review threads. Removed timeout and signal options from Both APIs now use the shared Build and flint passed. The changed and neighboring test files passed on Chromium, Firefox and WebKit: 772 passed, 2 skipped. The timeout check failed with the original client; all 12 feature checks failed without the implementation and passed after restoring it. Revised on Linux by the Playwright bot - agent run |
8e586d1 to
0ecb5a7
Compare
| const resolved = await progress.race(this.selectors.callOnSelectorHandle({ ...target, markTargets: 'all' }, ({ elements }) => elements[0] as Element, {})); | ||
| if (!resolved) | ||
| return null; | ||
| const handle = resolved.result; |
There was a problem hiding this comment.
This is conceptually wrong - you are retrying after resolution which is against Playwright principles. Look at how toBeVisible works probably - it is the closest to what you are trying to do.
There was a problem hiding this comment.
The current code already re-resolves on every assertion retry, as toBeVisible() does: _click(..., retry) selects _performPointerAction, not _retryPointerAction. A three-browser check confirmed one query for isClickable() and a fresh query for toBeClickable() that checked a replacement target, so I made no code change.
Revised on Linux by the Playwright bot - agent run
|
Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run |
This comment has been minimized.
This comment has been minimized.
|
Hi, I'm the Playwright bot. I checked the retry behavior and left the code unchanged. For the review comment, A custom-selector check confirmed this on Chromium, Firefox and WebKit: Revised on Linux by the Playwright bot - agent run |
0ecb5a7 to
c46dd12
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🟡 Likely unrelated, but one failure remains uncertainHi, I'm the Playwright bot. I checked the latest CI report for DetailsNo failure clearly points to this PR. The hard failure happened during page setup, before the test body ran. The separate UI-mode test is a confirmed pre-existing flake. Uncertain
Pre-existing flake
Triaged by the Playwright bot - agent run |
c46dd12 to
fa34662
Compare
Test results for "MCP"1 failed 5193 passed, 616 skipped Merge workflow run. |
🟢 Latest MCP failure is a pre-existing flakeHi, I'm the Playwright bot. I checked the latest MCP report. Its single failure is unlikely to be caused by this PR. DetailsThe failure matches one seen before this PR existed. There is no evidence of a regression from the clickability changes in this report. Pre-existing flake
Triaged by the Playwright bot - agent run |
Test results for "tests 1"Warning The triggering workflow run ended with status 18575 passed, 531 skipped Merge workflow run. |
Summary
Locator.isClickable(): runs the actionability checks of a click once (visible, stable, enabled, not inert, receives pointer events) without clicking and without a timeout.expect(locator).toBeClickable(): the same check inside the regular expect loop, so every poll resolves the locator again and cycles the scroll alignments likeclick().click().Fixes #43849