Repository navigation
fix(chromium): connect to a page that activated a prerender - #43854
Dmitry Gozman (dgozman) wants to merge 3 commits into
Conversation
When a prerendered page is activated, the tab keeps its target id, but the main frame gets a new id. Looking up the main frame session by frame id then fails, so the page is reported with a dummy main frame and never becomes usable. Introduce CRPage.isMainFrame(), CRPage.isLocalRoot(), CRPage.localRootSession() and FrameSession.localRoot(), and use them instead of comparing frame ids with target ids. Also log page initialization errors instead of swallowing them. Fixes: microsoft#43842
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🟢 All three failures predate this PRHi, I'm the Playwright bot. I checked the failed MCP run; the same three Chrome tests fail on DetailsCovers MCP run 43856794190 at Pre-existing flake / infra All three failures in
These are frequent pre-existing failures, not isolated retry failures: since November 9, each test failed in 63 of 64 recorded Chrome runs outside this PR, including 24 runs on Checked the failures on Linux by the Playwright bot - agent run |
🟢 Both failures predate this PRHi, I'm the Playwright bot. Both JUnit failures also occur on DetailsCovers tests 1 run 43856794313 for head Pre-existing flake / infra — existing test defect
Both tests fail identically in the Windows job on main, at This is a path-separator mismatch, not an intermittent failure: The MCP failures already have a separate verdict. The WebKit test that passed on retry is not counted as a failure. Checked the failures on Linux by the Playwright bot - agent run |
Test results for "tests 1"2 failed 23646 passed, 716 skipped Merge workflow run. |
🟢 Both failures predate this PRHi, I'm the Playwright bot. I checked the new run: both failures are existing Windows test errors, not regressions from this PR. DetailsCovers tests 1 run 43874427859 for head Pre-existing flake / infra — existing test defect
Both tests fail with that exact assertion in the Windows job on main, at The small fix is to use Checked the failures on Linux by the Playwright bot - agent run |
Test results for "MCP"3 failed 5232 passed, 631 skipped Merge workflow run. |
🟢 All three failures predate this PRHi, I'm the Playwright bot. I checked the new MCP run: the same three Chrome crash-recovery tests fail on DetailsCovers MCP run 43874427934 for head Pre-existing flake / infra All three failures in
I compared both jobs' logs directly. The PR's Chrome job introduces no new failure in this group. The PR changes Chromium frame/session selection, but leaves the crash-event handler and MCP crash-recovery code unchanged. These are confirmed pre-existing failures; the timeouts alone are not the basis for the verdict. The separate Windows JUnit failures for this head already have a verdict. Checked the failures on Linux by the Playwright bot - agent run |
Summary
connectOverCDPreported the page with a dummy main frame andtitle()/evaluate()never resolved.CRPage.isMainFrame(),CRPage.isLocalRoot(),CRPage.localRootSession()andFrameSession.localRoot(), and use them instead of comparing frame ids with target ids.Fixes #43842