Repository navigation
fix(browser): respect launchServer timeout - #43826
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| }); | ||
|
|
||
| it('BT-012 should handle timeout', async ({ browserType, mode }) => { | ||
| it('BT-012 should handle timeout', { annotation: { type: 'issue', description: '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/microsoft/playwright/issues/43819' } }, async ({ browserType, mode }) => { |
There was a problem hiding this comment.
This should be a separate test, where launch server tests are.
|
While you are here, relax AGENTS.md's bad for new tests in "Test Scope". Replace same feature with same feature and same api, that way launch and launchServer are not conflated |
|
Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run |
#43826 (comment): Move the timeout regression to its own launchServer test and restore the launch test; register the new test as BT-104. #43826 (comment): Require the same feature and the same API in the AGENTS.md test-extension rule.
Test results for "tests 1"1 failed 1 flaky23631 passed, 705 skipped Merge workflow run. |
🟢 The reported failure is a pre-existing flakeHi, I'm the Playwright bot. I compared the latest CI failure for DetailsThe latest test report has one failed test. It is unlikely to be caused by this PR: the change sets the Pre-existing flake
The reported Triaged by the Playwright bot - agent run |
Test results for "MCP"5194 passed, 616 skipped Merge workflow run. |
Playwright 1.65 honors launchServer's timeout (microsoft/playwright#43826), so a Firefox that never finishes starting fails after the boot budget instead of blocking every later open. Its Firefox 159 also starts on macOS 27. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
launchServer()computed the launch timeout but omitted it fromProgressController.run, leaving browser startup without a deadline since #36455. Pass the existing timeout value, preserving the documented default andtimeout: 0.Extend
BT-012 should handle timeoutwith a server-launch assertion. It fails without the fix and passes with it on Chromium, Firefox and WebKit. Both launch test files pass (77 passed, 1 existing skip), as do build and flint.Fixes #43819
Prepared by the triage workflow.