Repository navigation
fix(test runner): retain PWTEST_CACHE_DIR compatibility - #43802
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🟢 The CI failure is a pre-existing flakeHi, I'm the Playwright bot. I checked the failed job, PR diff and refreshed CI history. DetailsThe latest merged report has one failure. It is unlikely to be caused by this PR. Pre-existing flake
The same test failed on the same bot on main, October 23, SHA In this PR's failed job, The PR restores a cache-directory environment-variable fallback; it does not change Speedboard or duration sorting. This test's fixture already sets the higher-priority Triaged by the Playwright bot - agent run |
| PLAYWRIGHT_TRANSFORM_CACHE_DIR=~/.cache/playwright-transform npx playwright test | ||
| ``` | ||
|
|
||
| The legacy `PWTEST_CACHE_DIR` environment variable is also supported. If both variables are set, `PLAYWRIGHT_TRANSFORM_CACHE_DIR` takes precedence. |
There was a problem hiding this comment.
Let's not mention the legacy env in the docs.
|
Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run |
#43802 (comment): Removed the legacy cache environment variable paragraph from the docs; compatibility support and regression coverage remain unchanged.
b27bac6 to
4989af0
Compare
Test results for "MCP"5194 passed, 616 skipped Merge workflow run. |
Test results for "tests 1"23622 passed, 705 skipped Merge workflow run. |
Restore
PWTEST_CACHE_DIRas a fallback after the rename removed support for existing users.PLAYWRIGHT_TRANSFORM_CACHE_DIRtakes precedence when both variables are set; the default directory is unchanged.Extend the existing cache cleanup test to check the legacy override and precedence, and document both names.
Verified: the extended test fails without the fix; all 96 tests in
cache.spec.ts,loader.spec.ts, andesm.spec.tspass with it.npm run buildandnpm run flintpass.Fixes #43798
Prepared by the triage workflow.