Repository navigation
fix(expect): preserve screenshot assertion errors without comparison details - #43749
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| }); | ||
|
|
||
| test('should support omitBackground option for locator', async ({ runInlineTest }, testInfo) => { | ||
| test('should support omitBackground option for locator', { annotation: { type: 'issue', description: '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/microsoft/playwright/issues/43745' } }, async ({ runInlineTest }, testInfo) => { |
Collaborator
There was a problem hiding this comment.
Please make a new test for this.
| if (!(e instanceof PlaywrightError)) | ||
| throw e; | ||
| const details = e.details as channels.PageExpectScreenshotErrorDetails; | ||
| if (!details.customErrorMessage) |
Collaborator
There was a problem hiding this comment.
I think was regressed fairly recently. Let's find the culprit, and mention in the PR description.
Contributor
|
Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run |
#43749 (comment): Move the strict-mode regression into its own issue-tagged test and restore the omitBackground test, as requested. #43749 (comment): Identify 7cc4a85 (#40801) as the culprit: the new client catch converts strict-mode errors without comparison details into successful results. This read-only job cannot edit the PR description; record the suggested replacement in the run summary.
Contributor
Test results for "MCP"5194 passed, 616 skipped Merge workflow run. |
Contributor
Test results for "tests 1"23597 passed, 707 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver throws strict-mode errors without screenshot-comparison details. The client incorrectly treated these errors as successful captures, so an ambiguous locator could pass
toHaveScreenshot().Rethrow errors without a custom screenshot error message. Extend the existing locator screenshot test to check strictness against an existing baseline in update and regular runs.
Verified: build and
npm run flintpassed; 71 screenshot assertion tests and 63 nearby snapshot tests passed. The two-button check passed on Chromium, Firefox, and WebKit in update and regular modes.Regressed by #40801
Fixes: #43745
Prepared by the triage workflow.