Repository navigation
fix(fetch): handle destroyed reused TLS sockets - #43729
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 The reported failure is a pre-existing flakeHi, I'm the Playwright bot. I checked the CI report, PR changes, and refreshed test history. DetailsThe single failure in the latest MCP report is unlikely to be caused by this PR. Pre-existing flake
The same test failed on This PR only guards certificate capture for destroyed TLS sockets in Triaged by the Playwright bot - agent run |
This comment has been minimized.
This comment has been minimized.
| return; | ||
| const protocol = socket.getProtocol() ?? undefined; | ||
| const peerCertificate = socket.getPeerCertificate(); | ||
| if (!peerCertificate) |
There was a problem hiding this comment.
Let's add a comment that getPeerCertificate() can return null for an already-destroyed socket, and link to the issue.
| }); | ||
|
|
||
| it('FE-021 should return security details from response', async ({ playwright, httpsServer }) => { | ||
| it('FE-021 should return security details from response', { |
There was a problem hiding this comment.
Let's undo changes to the test.
|
Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run |
|
Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run |
#43729 (comment): Explain that getPeerCertificate() can return null for an already-destroyed socket and link to the issue. #43729 (comment): Undo all changes to the security-details test, including the added import and issue annotation.
Test results for "MCP"5194 passed, 616 skipped Merge workflow run. |
Test results for "tests 1"1 flaky23596 passed, 707 skipped Merge workflow run. |
Handle a null peer certificate when a destroyed keep-alive TLS socket is assigned to an API request. Certificate capture no longer throws from the socket listener; the request still rejects through its normal connection-error path.
Extend the existing security-details test to check the destroyed-socket case, while retaining fresh-connection and keep-alive certificate assertions.
Verified the regression fails without the fix. With the fix, the global-fetch and browsercontext-fetch specs passed in Chromium, Firefox, and WebKit projects (613 passed, 2 skipped). Build, flint, and diff checks passed.
Fixes: #43728
Prepared by the triage workflow.