Skip to content

test: nested display:contents scrollIntoView - #43717

Merged
Dmitry Gozman (dgozman) merged 2 commits into
microsoft:mainfrom
dgozman:test-scroll-double-display-contents
Oct 28, 2026
Merged

Dmitry Gozman (dgozman) merged 2 commits into
microsoft:mainfrom
dgozman:test-scroll-double-display-contents

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@dgozman Dmitry Gozman (dgozman) left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint bot issue

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

23590 passed, 707 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [chrome] › mcp/cli-session.spec.ts:147 › session stops when temporary socket directory disappears @mcp-macos-latest-chrome

5188 passed, 614 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 The CI failure is a pre-existing flake, not caused by this PR

Hi, I'm the Playwright bot. I checked the latest CI reports, the PR diff, and the failing test's history.

Details

The latest reports show one MCP failure; the library and test-runner jobs passed. This PR only adds a nested display:contents scrolling test and its registry entry. It does not change the CLI session code exercised by the failure.

Pre-existing flake

[chrome] › mcp/cli-session.spec.ts:147 › session stops when temporary socket directory disappears on mcp-macos-latest-chrome — in the failing job, the daemon was still alive after the 5-second polling deadline at line 164.

The same test failed on the same macOS bot with the identical assertion and timeout on October 22 in #43570 (run 39745384420, attempt 1), before this PR. Excluding #43717, the refreshed test-results database records 691 passing runs and one failing run for this exact test and bot. This confirms a pre-existing intermittent failure rather than a regression from this PR.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit d6d086d into microsoft:main Oct 28, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants