Repository navigation
fix(webkit): default to one stable animation frame - #43673
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| it('EH-122 should wait for stable position', { annotation: { type: 'issue', description: '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/microsoft/playwright/issues/43632' } }, async ({ page, server, browserName, mode, toImplInWorkerScope }) => { | ||
| if (mode === 'default') { | ||
| const expectedRafCount = browserName === 'webkit' && process.env.PLAYWRIGHT_WEBKIT_RAF_COUNT_FIX ? 5 : 1; | ||
| expect(toImplInWorkerScope(page).delegate.rafCountForStablePosition()).toBe(expectedRafCount); |
Collaborator
There was a problem hiding this comment.
Drop this change to the test, except for the annotation.
Contributor
|
Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run |
#43673 (comment): Remove the frame-count assertion and restore the original fixtures, keeping only the issue annotation as requested. Build, flint, and all 75 tests passed. EH-122 passed on all browsers both without and with the fix; removing the assertion leaves no failing regression check, and this Linux runner cannot verify the original Windows failure.
Contributor
Test results for "MCP"5189 passed, 614 skipped Merge workflow run. |
Contributor
Test results for "tests 1"2 flaky23574 passed, 706 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
approved these changes
Oct 29, 2026
Dmitry Gozman (dgozman)
marked this pull request as ready for review
October 29, 2026 11:26
Contributor
Test results for "tests 2"18 flaky127074 passed, 4126 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
approved these changes
Oct 29, 2026
Pavel Feldman (pavelfeldman)
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebKit still required five stable comparisons on Windows because of the old animation-frame workaround. Default to one comparison, as requested, and restore five comparisons and the existing minimum sampling interval when
PLAYWRIGHT_WEBKIT_RAF_COUNT_FIX=1is set.Extend EH-122 to check the selected frame count while retaining its moving-element check. The new assertion fails on unmodified Windows WebKit (expected 1, received 5).
Verified on Windows: build and flint passed; the click, stable-state and click-timeout specs passed on Chromium, Firefox and WebKit (323 passed, 1 skipped). CL-042 and EH-122 passed 10 repeats each in headed and headless WebKit with both the default and fallback (80 passed).
Fixes: #43632
Prepared by the triage workflow.