Skip to content

fix(webkit): default to one stable animation frame - #43673

Merged
Dmitry Gozman (dgozman) merged 2 commits into
mainfrom
triage/43632/40521472414-1
Oct 29, 2026
Merged

Dmitry Gozman (dgozman) merged 2 commits into
mainfrom
triage/43632/40521472414-1

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

WebKit still required five stable comparisons on Windows because of the old animation-frame workaround. Default to one comparison, as requested, and restore five comparisons and the existing minimum sampling interval when PLAYWRIGHT_WEBKIT_RAF_COUNT_FIX=1 is set.

Extend EH-122 to check the selected frame count while retaining its moving-element check. The new assertion fails on unmodified Windows WebKit (expected 1, received 5).

Verified on Windows: build and flint passed; the click, stable-state and click-timeout specs passed on Chromium, Firefox and WebKit (323 passed, 1 skipped). CL-042 and EH-122 passed 10 repeats each in headed and headless WebKit with both the default and fallback (80 passed).

Fixes: #43632

Prepared by the triage workflow.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

it('EH-122 should wait for stable position', { annotation: { type: 'issue', description: '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/microsoft/playwright/issues/43632' } }, async ({ page, server, browserName, mode, toImplInWorkerScope }) => {
if (mode === 'default') {
const expectedRafCount = browserName === 'webkit' && process.env.PLAYWRIGHT_WEBKIT_RAF_COUNT_FIX ? 5 : 1;
expect(toImplInWorkerScope(page).delegate.rafCountForStablePosition()).toBe(expectedRafCount);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this change to the test, except for the annotation.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run

#43673 (comment): Remove the frame-count assertion and restore the original fixtures, keeping only the issue annotation as requested. Build, flint, and all 75 tests passed. EH-122 passed on all browsers both without and with the fix; removing the assertion leaves no failing regression check, and this Linux runner cannot verify the original Windows failure.
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5189 passed, 614 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 flaky ⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@chromium-playwright-x64-ubuntu24-64-core-node22`
⚠️ [firefox-library] › library/capabilities.spec.ts:105 › CA-008 should support webgl Radoslav Kirilov (@smoke) `@firefox-playwright-x64-ubuntu24-64-core-node22`

23574 passed, 706 skipped


Merge workflow run.

@dgozman
Dmitry Gozman (dgozman) marked this pull request as ready for review October 29, 2026 11:26
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

18 flaky ⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@chromium-playwright-x64-server2025-64-core`
⚠️ [chromium-library] › library/beforeunload.spec.ts:20 › BU-001 should close browser with beforeunload page `@chromium-macos-15-large`
⚠️ [chromium-library] › library/browsercontext-basic.spec.ts:36 › BC-002 should be able to click across browser contexts `@chromium-macos-15-large`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:80 › CD-003 should connect when the opener of an existing page has no renderer `@chromium-macos-15-large`
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:202 › cli codegen › CG-046 should upload a file via hidden input triggered by button `@chromium-macos-15-large`
⚠️ [chromium-library] › library/popup.spec.ts:279 › PO-028 should not throw when click closes popup `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › VI-014 should work for popups `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/webmcp.spec.ts:238 › WM-013 should call same-name tools in their own frame `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/popup.spec.ts:279 › PO-028 should not throw when click closes popup `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@chromium-ubuntu-22.04-arm-node22`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:43 › WA-004 should poll on interval `@tracing-firefox`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1937 › TV-087 should not leak recorders `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/beforeunload.spec.ts:20 › BU-001 should close browser with beforeunload page `@webkit-playwright-x64-server2025-64-core`
⚠️ [webkit-library] › library/heap.spec.ts:304 › LE-014 cycle handles `@webkit-playwright-x64-server2025-64-core`
⚠️ [webkit-page] › page/page-keyboard.spec.ts:585 › KB-044 should support simple cut-pasting `@webkit-playwright-x64-server2025-64-core`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:2009 › TV-089 canvas disabled title `@webkit-macos-15-xlarge`
⚠️ [webkit-page] › page/wheel.spec.ts:154 › MO-022 should scroll horizontally `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1937 › TV-087 should not leak recorders `@webkit-macos-15-large`

127074 passed, 4126 skipped


Merge workflow run.

@dgozman
Dmitry Gozman (dgozman) merged commit 240d3ce into main Oct 29, 2026
59 checks passed
@dgozman
Dmitry Gozman (dgozman) deleted the triage/43632/40521472414-1 branch October 29, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: WebKit on Windows waits for 5 stable animation frames per action, a workaround that no longer seems needed

2 participants