Skip to content

chore(chromium): link the crbug for detaching without resuming - #43667

Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:fix-43562
Oct 27, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:fix-43562

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

Summary

References #43562

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace @chromium-playwright-x64-ubuntu24-64-core-node22

23560 passed, 702 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5189 passed, 614 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 The CI test failure is a confirmed pre-existing flake

Hi, I'm the Playwright bot. I compared the failure with this PR and the refreshed CI test history.

Details

The merged tests 1 report has one failed test; the MCP report has none. This PR only adds three comment lines in crConnection.ts and crPage.ts, with no executable code changes. The failure is not caused by this PR.

Pre-existing flake

[chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace — fails on all four attempts here. The trace has no screencast-frame event, so reading frame.file at line 790 throws TypeError: Cannot read properties of undefined (reading 'file').

The refreshed test-results database confirms the same test, on the same Linux bot, failed twice with the same error and then passed on main at this PR's base commit, c409f8c83ec, before this PR ran: main run. Across 144 runs outside this PR on that bot, it ultimately failed in 15 and passed in 129; 77 of those passes required a retry.

This verdict covers the reported test failures; docs & lint was still running when checked.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit 6d2b35b into microsoft:main Oct 27, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants