Skip to content

docs(api): fix examples that call nonexistent APIs - #43393

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
Super-Eric:fix-docs-nonexistent-api-examples
Oct 14, 2026
Merged

Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
Super-Eric:fix-docs-nonexistent-api-examples

Conversation

@Super-Eric

Copy link
Copy Markdown
Contributor

Summary

  • BrowserContext.routeWebSocket: WebSocketRoute has no routeSend/connect in any language; use connectToServer + onMessage, as the WebSocketRoute docs do.
  • Page.screencast: Screencast has no 'screencastFrame' event; frames are delivered through the onFrame option of start().
  • Frame.selectOption: multiple values are passed as an array, matching the Page.selectOption example.
  • TestConfig.webServer: the fixture option is baseURL, not baseUrl.

- BrowserContext.routeWebSocket: WebSocketRoute has no routeSend/connect in
  any language; use connectToServer + onMessage, as the WebSocketRoute docs do.
- Page.screencast: Screencast has no 'screencastFrame' event; frames are
  delivered through the onFrame option of start().
- Frame.selectOption: multiple values are passed as an array, matching the
  Page.selectOption example.
- TestConfig.webServer: the fixture option is baseURL, not baseUrl.
@yury-s
Yury Semikhatsky (yury-s) merged commit 9690e49 into microsoft:main Oct 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

5 failed
❌ [playwright-test] › playwright.spec.ts:1131 › should pause test timeout while on pause @playwright-x64-server2025-64-core-node22
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:432 › should toggle sections inside network details with keyboard @playwright-x64-server2025-64-core-node22
❌ [playwright-test] › web-server.spec.ts:495 › should send Accept header @playwright-x64-server2025-64-core-node22
❌ [playwright-test] › web-server.spec.ts:524 › should follow redirects @playwright-x64-server2025-64-core-node22
❌ [webkit-library] › library/proxy.spec.ts:180 › should reconnect with credentials after CONNECT 407 closes the socket @webkit-ubuntu-22.04-node22

5 flaky ⚠️ [playwright-test] › ui-mode-trace.spec.ts:388 › should reveal errors in the sourcetab `@playwright-x64-server2025-64-core-node22`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:715 › should indicate current test status `@playwright-x64-server2025-64-core-node22`
⚠️ [chromium-library] › library/chromium/css-coverage.spec.ts:112 › should report stylesheets across navigations `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node22`

21787 passed, 525 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [chromium] › mcp/webmcp-dynamic.spec.ts:189 › a tool registered in an iframe can be called after the page is reloaded @mcp-ubuntu-latest-chromium

9203 passed, 1495 skipped


Merge workflow run.

@Super-Eric
Super-Eric deleted the fix-docs-nonexistent-api-examples branch October 15, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants