fix(tracing): copy WebSocket message files before zipping - #41382
Merged
Conversation
Devin Rousso (dcrousso)
requested review from
Dmitry Gozman (dgozman) and
Yury Semikhatsky (yury-s)
June 19, 2026 18:10
Yury Semikhatsky (yury-s)
approved these changes
Jun 19, 2026
| onContentBlobAppend(sha1: string, text: string) { | ||
| if (!this._allResources.has(sha1)) | ||
| this._allResources.add(sha1); | ||
| this._state!.appendableSha1s.add(sha1); |
There was a problem hiding this comment.
should the entry be removed from the set at some point?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
`SerializedFS` ensures that we won't ever perform multiple filesystem operations at the same time unfortuntately, if the caller is doing their own zipping (i.e. `mode: 'entries'`) there is no such guarantee
Devin Rousso (dcrousso)
force-pushed
the
fix-41200
branch
from
June 19, 2026 20:23
5201e7c to
9b321f8
Compare
Contributor
Test results for "MCP"7354 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 failed 4 flaky48907 passed, 1142 skipped Merge workflow run. |
Devin Rousso (dcrousso)
merged commit Jun 19, 2026
3288351
into
microsoft:main
47 of 48 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SerializedFSensures that we won't ever perform multiple filesystem operations at the same timeunfortuntately, if the caller is doing their own zipping (i.e.
mode: 'entries') there is no such guaranteefixes #41351