Skip to content

docs: document promise unwrapping - #39719

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
AndyOGo:docs/promise-unwrapping-39027
Mar 20, 2026
Merged

Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
AndyOGo:docs/promise-unwrapping-39027

Conversation

@AndyOGo

@AndyOGo Andreas (AndyOGo) commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

fixes #39027

Inspired by similar Jest's modifiers .resolves/.rejects.

@AndyOGo

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Comment thread docs/src/api/class-genericassertions.md Outdated
Comment thread docs/src/api/class-genericassertions.md Outdated
@AndyOGo
Andreas (AndyOGo) force-pushed the docs/promise-unwrapping-39027 branch 2 times, most recently from abaa285 to 3a6c58a Compare March 18, 2026 18:24

@yury-s Yury Semikhatsky (yury-s) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but lint is not happy. You need to update type overrides in utils/generate_types/overrides-test.d.ts.

@AndyOGo
Andreas (AndyOGo) force-pushed the docs/promise-unwrapping-39027 branch 2 times, most recently from 2c5a64b to e18defc Compare March 19, 2026 18:22

@yury-s Yury Semikhatsky (yury-s) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but lint is not happy.

@AndyOGo

Copy link
Copy Markdown
Contributor Author

The change looks good, but lint is not happy.

Yury Semikhatsky (@yury-s) Okay. That lint step here passed. Is there another lint I should check?
https://github.com/microsoft/playwright/actions/runs/23310423478/job/67858093654?pr=39719

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5507 passed, 343 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

10 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:358 › screencast › should capture navigation `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-node22`
⚠️ [webkit-library] › library/screencast.spec.ts:85 › start reuses existing screencast when video recording is running `@webkit-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@webkit-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-network-request.spec.ts:288 › should parse the data if content-type is application/x-www-form-urlencoded `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:465 › should filter actions tab on double-click `@windows-latest-node20`

38811 passed, 845 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs]: Promise unwrapping not documented (with .resolves/.rejects)

3 participants