fix(api): migrate Screencast from events to onFrame callback - #39714
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoMar 18, 2026
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
Pavel Feldman (pavelfeldman) merged 1 commit into
Conversation
Yury Semikhatsky (yury-s)
approved these changes
Mar 17, 2026
Pavel Feldman (pavelfeldman)
force-pushed
the
screencast-onframe-callback
branch
from
March 18, 2026 21:58
144777d to
59eae36
Compare
Dmitry Gozman (dgozman)
approved these changes
Mar 18, 2026
|
|
||
| Maximum screencast frame dimensions. The output frame may be smaller to preserve the page aspect ratio. Defaults to 800×800. | ||
|
|
||
| ### option: Screencast.start.onFrame |
Collaborator
There was a problem hiding this comment.
Why is this an option, and not a first argument?
| ### option: Screencast.start.onFrame | ||
| * since: v1.59 | ||
| * langs: js | ||
| - `onFrame` ?<[function]\([Buffer]\)> |
Collaborator
There was a problem hiding this comment.
To show that it can be async:
Suggested change
| - `onFrame` ?<[function]\([Buffer]\)> | |
| - `onFrame` <[function]\([Buffer]\): [Promise<any>|any]> |
| } | ||
|
|
||
| export interface Screencast { | ||
| start(options?: { |
Collaborator
There was a problem hiding this comment.
Since page.route() does not need an override, I hope this one doesn't need one either.
Pavel Feldman (pavelfeldman)
force-pushed
the
screencast-onframe-callback
branch
from
March 18, 2026 23:05
59eae36 to
2bdc7ea
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yury Semikhatsky (yury-s)
approved these changes
Mar 18, 2026
|
|
||
| async start(options: { maxSize?: { width: number, height: number } } = {}) { | ||
| async start(onFrame: (buffer: Buffer) => any, options: { maxSize?: { width: number, height: number } } = {}): Promise<DisposableStub> { | ||
| this._onFrame = onFrame; |
There was a problem hiding this comment.
throw if non-null?
Pavel Feldman (pavelfeldman)
merged commit Mar 18, 2026
bf1f743
into
microsoft:main
36 of 37 checks passed
Contributor
Test results for "tests 1"5 flaky38809 passed, 845 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 5506 passed, 343 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.