chore: screencast/tracing/video size conflicts - #39512
Merged
Yury Semikhatsky (yury-s) merged 7 commits intoMar 5, 2026
Merged
Conversation
Yury Semikhatsky (yury-s)
force-pushed
the
video-screencast-size
branch
from
March 4, 2026 20:24
d240efa to
ca4898c
Compare
| const size = params.size || this._page.emulatedSize()?.viewport || { width: 800, height: 600 }; | ||
| // TODO: move to screencast and make startScrencast accept a listener. | ||
| this._screencastFrameListener = eventsHelper.addEventListener(this._page, Page.Events.ScreencastFrame, (frame: ScreencastFrame) => { | ||
| const { width, height } = jpegDimensions(frame.buffer); |
Collaborator
There was a problem hiding this comment.
Doesn't ScreencastFrame already contain width/height?
Member
Author
There was a problem hiding this comment.
No. Those are original device width/height.
|
|
||
| async startScreencast(params: channels.PageStartScreencastParams, progress?: Progress): Promise<channels.PageStartScreencastResult> { | ||
| const size = validateVideoSize(params.size, this._page.emulatedSize()?.viewport); | ||
| if (this._screencastFrameListener) |
Collaborator
There was a problem hiding this comment.
Why this change? I don't quite understand.
Member
Author
There was a problem hiding this comment.
We don't want to send screencastframe events if screencast is disabled, there is new test that checks that. Previously if video started we'd start dispatching screencastframe events.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pavel Feldman (pavelfeldman)
approved these changes
Mar 4, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yury Semikhatsky (yury-s)
force-pushed
the
video-screencast-size
branch
from
March 5, 2026 00:07
01e2310 to
d648efe
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yury Semikhatsky (yury-s)
merged commit Mar 5, 2026
e138792
into
microsoft:main
35 of 36 checks passed
Yury Semikhatsky (yury-s)
added a commit
to yury-s/playwright
that referenced
this pull request
Mar 5, 2026
Yury Semikhatsky (yury-s)
added a commit
that referenced
this pull request
Mar 5, 2026
Contributor
Test results for "MCP"3 failed 5221 passed, 171 skipped Merge workflow run. |
Contributor
Test results for "tests 1"5 flaky38798 passed, 841 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.