feat(api): introduce disposable return values - #39504
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoMar 4, 2026
Merged
Conversation
Pavel Feldman (pavelfeldman)
force-pushed
the
disposable_api
branch
from
March 4, 2026 04:22
06a589f to
5759346
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| return Disposable.from((await this._channel.addInitScript({ source })).disposable); | ||
| } | ||
|
|
||
| async exposeBinding(name: string, callback: (source: structs.BindingSource, ...args: any[]) => any, options: { handle?: boolean } = {}): Promise<void> { |
There was a problem hiding this comment.
Update the signature in the .md?
| return Disposable.from(result.disposable); | ||
| } | ||
|
|
||
| async exposeFunction(name: string, callback: Function): Promise<void> { |
Dmitry Gozman (dgozman)
approved these changes
Mar 4, 2026
Pavel Feldman (pavelfeldman)
force-pushed
the
disposable_api
branch
from
March 4, 2026 16:32
5759346 to
0cbfaf8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pavel Feldman (pavelfeldman)
force-pushed
the
disposable_api
branch
from
March 4, 2026 17:18
0cbfaf8 to
aa58d24
Compare
Yury Semikhatsky (yury-s)
approved these changes
Mar 4, 2026
Contributor
Test results for "tests 1"6 flaky38790 passed, 841 skipped Merge workflow run. |
Contributor
Test results for "MCP"4 failed 5220 passed, 171 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
merged commit Mar 4, 2026
528c704
into
microsoft:main
35 of 38 checks passed
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.