chore: devtools experiment - #39204
Merged
Merged
Conversation
Pavel Feldman (pavelfeldman)
force-pushed
the
rc2
branch
from
February 10, 2026 02:08
d31be12 to
91d0293
Compare
Yury Semikhatsky (yury-s)
approved these changes
Feb 10, 2026
| } | ||
|
|
||
| close() { | ||
| this._ws.close(); |
There was a problem hiding this comment.
reject pending?
| 'version', | ||
| ]; | ||
|
|
||
| const booleanOptions: (keyof (GlobalOptions & OpenOptions & { all?: boolean }))[] = [ |
There was a problem hiding this comment.
why did this change?
Member
Author
There was a problem hiding this comment.
because those are a part of commands.js
|
|
||
| if (config.sessionConfig) { | ||
| const contextFactory = config.extension ? extensionContextFactory : browserContextFactory; | ||
| console.log(`### Config`); |
There was a problem hiding this comment.
revert this part
Member
Author
There was a problem hiding this comment.
it is quite important - we want to print config after running this code.
Pavel Feldman (pavelfeldman)
force-pushed
the
rc2
branch
from
February 10, 2026 03:20
91d0293 to
310f24f
Compare
Pavel Feldman (pavelfeldman)
merged commit Feb 10, 2026
31572b6
into
microsoft:main
32 of 33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.