Skip to content

Commit 1919431

Browse files
fix(fetch): handle destroyed reused TLS sockets (#43729)
Co-authored-by: microsoft-playwright-automation[bot] <203992400+microsoft-playwright-automation[bot]@users.noreply.github.com>
1 parent 565f39b commit 1919431

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

  • packages/playwright-core/src/server

‎packages/playwright-core/src/server/fetch.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -597,6 +597,10 @@ export abstract class APIRequestContext extends SdkObject {
597597
return;
598598
const protocol = socket.getProtocol() ?? undefined;
599599
const peerCertificate = socket.getPeerCertificate();
600+
// getPeerCertificate() can return null for an already-destroyed socket.
601+
// See https://github.com/microsoft/playwright/issues/43728.
602+
if (!peerCertificate)
603+
return;
600604
if (!peerCertificate.valid_from) {
601605
// A resumed TLS session returns an empty getPeerCertificate(), and we use the cached data.
602606
securityDetails = { ...this._certificateDetails.get(certificateCacheKey), protocol };

0 commit comments

Comments
 (0)