Repository navigation
Improve Stack Names For Dynamically Generated JIT Helpers - #2455
Merged
Brian Robbins (brianrob) merged 2 commits intoAug 18, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Lee Culver (leculver)
approved these changes
Aug 18, 2026
|
|
||
| // TODO FIX NOW remove the jittedMethods ones. | ||
| private List<MethodLoadUnloadVerboseTraceData> jittedMethods; | ||
| // TODO FIX NOW remove the methodLoadEvents ones. |
Collaborator
There was a problem hiding this comment.
Is this TODO FIX NOW still relevant? If so, maybe a more in-depth comment about what's going here would be helpful.
Member
Author
There was a problem hiding this comment.
I don't think this is relevant anymore, but I need to check. There are a lot of these, and I've been thinking about doing a pass over them to clean things up. I'll plan to handle this as part of that pass.
This was referenced Aug 20, 2026
Merged
deps(nuget): Bump Microsoft.Diagnostics.Tracing.TraceEvent from 3.2.5 to 3.2.6
adsamcik/WireBound#65
Merged
Merged
Open
This was referenced Aug 28, 2026
This was referenced Sep 6, 2026
This was referenced Sep 14, 2026
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates ETLX conversion to recognize
JitHelpermethod events from both live and rundown providers.JIT helpers are associated with a process-specific synthetic module and displayed as:
For example:
Non-helper method resolution remains unchanged.