This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Fixup onefuzz-task dependencies - #3552
Merged
Merged
Conversation
George Pollard (Porges)
marked this pull request as ready for review
October 5, 2023 21:10
Codecov Report
@@ Coverage Diff @@
## main #3552 +/- ##
=======================================
Coverage 38.97% 38.97%
=======================================
Files 301 301
Lines 36848 36848
=======================================
Hits 14363 14363
Misses 22485 22485
|
Kanan B (kananb)
approved these changes
Oct 5, 2023
Cheick Keita (chkeita)
approved these changes
Oct 5, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the bin and lib for
onefuzz-taskinclude the same modules, which means some code is being compiled twice, and this leads to confusing errors if you update the bin code and not the lib code (e.g. adding new modules or something similar).Instead, make the bin code depend on the lib code.
Also remove
extern crateandmacro_use, which are an older way of doing things. Macros are simply imported now.