Skip to content

@electron/universal fails to process node-pty >= 1.1.0-beta36 #863

Description

I upgraded node-pty to 1.2.0-beta.2 which caused the build to fail with the following error:

⨯ Detected file "Contents/Resources/app.asar.unpacked/node_modules/node-pty/prebuilds/darwin-arm64/pty.node" that's the same in both x64 and arm64 builds and not covered by the x64ArchFiles rule: "Contents/MacOS/tsh.app/Contents/MacOS/tsh"
at makeUniversalApp (/Users/runner/work/project/node_modules/.pnpm/@electron+universal@2.0.3/node_modules/@electron/universal/src/index.ts:181:17)

I noticed that since 1.1.0-beta36, the node-pty npm package ships with the prebuilds directory. Should @electron/universal be set up to ignore files in this directory?

I'm also worried if it means that the size of the app that includes node-pty is going to be increased by 60 MB of prebuilt binaries from win32 directories.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions