[release-branch.go1.26] Bump go-crypto-winnative to latest - #2467
Open
Quim Muntal (qmuntal) wants to merge 1 commit into
Open
[release-branch.go1.26] Bump go-crypto-winnative to latest#2467Quim Muntal (qmuntal) wants to merge 1 commit into
Quim Muntal (qmuntal) wants to merge 1 commit into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the vendored external dependency set to bump github.com/microsoft/go-crypto-winnative from 832b168a84e9 to 418c3f76f8f8 on the release-branch.go1.26 branch, aligning the Go tree’s vendored crypto backend dependencies with the newer upstream revision.
Changes:
- Bumped
go-crypto-winnativeversion in the vendoring patch (includingsrc/go.mod,src/go.sum, andsrc/vendor/modules.txtupdates within the patch). - Updated vendored CNG implementation content (notably adding ML-DSA support and other API/implementation updates in the vendored tree captured by the patch).
- Updated/added vendored internal
bcryptstructures and constants (including arch-specific struct layout handling).
Show a summary per file
| File | Description |
|---|---|
| patches/0001-Vendor-external-dependencies.patch | Updates the vendoring patch contents to the newer go-crypto-winnative revision and associated vendored files/metadata. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (1)
patches/0001-Vendor-external-dependencies.patch:36830
- PublicKeyMLDSA.Bytes returns a slice backed by the key's internal array, so callers can mutate the key object by modifying the returned slice. Return a copy to keep the PublicKeyMLDSA value immutable.
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
Comment on lines
37333
to
37337
| @@ -36902,6 +37337,7 @@ index 00000000000000..5466b180e60e5a | |||
| + out := make([]byte, keyLen) | |||
Comment on lines
+36768
to
+36770
| +func (key *PrivateKeyMLDSA) Bytes() []byte { | ||
| + return key.seed[:] | ||
| +} |
Davis Goodin (dagood)
requested changes
Aug 21, 2026
Davis Goodin (dagood)
left a comment
Davis Goodin (dagood)
left a comment
Member
There was a problem hiding this comment.
This could be fine, but when we do have support branches I would default to sticking with them.
| + github.com/microsoft/go-crypto-darwin v0.0.3-0.20260612173401-95c9561b6f25 | ||
| + github.com/microsoft/go-crypto-openssl v0.0.0-20260709090821-4e7f148608fd | ||
| + github.com/microsoft/go-crypto-winnative v0.0.0-20260127024749-832b168a84e9 | ||
| + github.com/microsoft/go-crypto-winnative v0.0.0-20260821094543-418c3f76f8f8 |
There was a problem hiding this comment.
Doesn't match tip of ms-go1.26-support, d3f2d4e543ce11be5e0da39c242233f48e3c4838 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates go-crypto-winnative from 832b168a84e9 to 418c3f76f8f8.
Tests: