go.mod: remove golang.org/x/tools dependency - #266
Closed
Sebastiaan van Stijn (thaJeztah) wants to merge 1 commit into
Closed
Sebastiaan van Stijn (thaJeztah) wants to merge 1 commit into
Sebastiaan van Stijn (thaJeztah) wants to merge 1 commit into
Conversation
This removes golang.org/x/tools/cmd/stringer as a direct dependency of this
module, instead using "go install" to install the required tool as part of
`go generate`. I opted for pinning to a fixed version for reproducibility, but
we could switch to `@latest` if there's no concerns for getting newer versions.
With this patch:
which stringer
# (no output)
go generate ./pkg/guid
which stringer
/Users/thajeztah/go/bin/stringer
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn (thaJeztah)
requested a review
from a team
as a code owner
November 9, 2022 12:11
Contributor
Author
Contributor
|
I don't think I understand the need for this. If trimming the dependencies for upstream projects is the goal, starting in go1.17, Also, using |
This was referenced Dec 23, 2022
Contributor
|
This is way old and we just replaced it. So closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes golang.org/x/tools/cmd/stringer as a direct dependency of this module, instead using "go install" to install the required tool as part of
go generate. I opted for pinning to a fixed version for reproducibility, but we could switch to@latestif there's no concerns for getting newer versions.With this patch: