C23 const fixes - #901
Merged
Merged
Conversation
Accommodate for C23 enforcing `const`-ness of `strchr()`'s return value. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
We need to accommodate for C23 being very strict about the `const`-ness of the return value of the `strchr()` function. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Johannes Schindelin (dscho)
requested a review
from Matthew John Cheetham (mjcheetham)
April 28, 2026 12:30
Derrick Stolee (derrickstolee)
approved these changes
Apr 28, 2026
Johannes Schindelin (dscho)
merged commit Apr 28, 2026
2bb9f4f
into
vfs-2.54.0
267 of 269 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the two patches from #900 that were not backports to
vfs-2.54.0, to appease the C23construles ofstrchr()/strrchr()/memchr()(which are now in effect due to Fedora 44 being used infedora-breaking-changes.