Skip to content

fix color for dropdown checkable indicator in hc theme #20621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Oleksandr Fediashov (layershifter) merged 4 commits into from
Nov 16, 2021
Merged

fix color for dropdown checkable indicator in hc theme #20621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
451c47f
fix color for dropdown checkable indicator for hc theme
Nov 16, 2021
9ed705e
update changelog
Nov 16, 2021
7abc009
update changelog
Nov 16, 2021
ff2704b
update dropdown styles
Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/fluentui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Fix `Alert` components to properly pass ref to root slots @chpalac ([#20582](https://github.com/microsoft/fluentui/pull/20582))
- Fix `Avatar` Components to properly pass ref to root slots @chpalac ([#20588](https://github.com/microsoft/fluentui/pull/20588))
- Fix `ButtonGroup` comoponent to properly pass ref to root slots @chpalac ([#20595](https://github.com/microsoft/fluentui/pull/20595))
- Fix color of `Dropdown` checkable indicator on hover in high contrast theme @annabratseiko ([#20621](https://github.com/microsoft/fluentui/pull/20621))

### Features
- Adding `ViewPersonSparkleIcon`, `CartIcon`, and fixing `EmojiAddIcon` and `AccessibilityIcon` - @notandrew ([#20054](https://github.com/microsoft/fluentui/pull/20054))
Expand Down
5 changes: 4 additions & 1 deletion packages/fluentui/react-northstar/src/themes/teams/components/Dropdown/dropdownItemStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,11 @@ export const dropdownItemStyles: ComponentSlotStylesPrepared<DropdownItemStylesP
fontSize: v.listItemContentFontSize,
color: v.listItemContentColor,
}),
checkableIndicator: ({ variables: v }) => ({
checkableIndicator: ({ props: p, variables: v }) => ({
backgroundImage: checkableIndicatorUrl(v.listItemSelectedColor),
...(p.active && {
backgroundImage: checkableIndicatorUrl(v.listItemColorHover),
}),
backgroundPosition: 'center',
backgroundRepeat: 'no-repeat',
position: 'absolute',
Expand Down