Infrastructure: land the public desktop driver - #4294
Merged
Conversation
…tive into user/jasonvmo/storybook-desktop
…tive into user/jasonvmo/storybook-desktop
Keep the shared smoke lifecycle, remove the dedicated Windows Jest harness, and preserve the platform exclusions required by current native hosts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size reportTree-shaken production Metro bundles. Component costs are relative to their platform shell; shell costs are absolute.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Install the required Windows App Runtime in CI, wait for the initial macOS Metro bundle, and stop the exact macOS app process reliably. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Register the SDK-provided Debug VCLibs framework before the app package and make the desktop-driver cancellation test deterministic on slower CI hosts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Register both x64 VCLibs Debug framework packages from the Windows SDK before installing the Storybook app package. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Anandraj (mganandraj)
approved these changes
Aug 31, 2026
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@fluentui-react-native/desktop-driverpackage with a client-neutral W3C remote end, deterministic fake host, typed client, WebdriverIO runner, JSON CLI, bounded agent API, and confined artifacts.apps/storybook/scriptsandwindows-testsharnesses in favor of the sharedstorybook-desktopCLI.smoke --mode stories|stories-and-tests, plus Windows and Win32 PR smoke jobs with artifact upload; macOS build steps now use the same shared CLI.This supersedes the older Appium-oriented branch shape described in #4258 with the fresh Appium-free Stage 1 architecture.
Infrastructure workstream coverage
main#4258.parameters.desktopDriverplans; the broader accessibility cohort, normalization table, and report summary remain open.Current platform boundary
storiestraverses the complete supported native catalog.stories-and-testsperforms the same traversal and then runs tagged authored plans against the Stage 1 manifest-derived fake target.Validation
yarn buildyarn workspace @fluentui-react-native/storybook-desktop test --runInBand— 33 tests passedyarn lint-lockfileyarn change:checkyarn check-publishingstories-and-tests— 136 native stories and 3 authored plans passedstories-and-tests— 130 native stories and 3 authored plans passed