Skip to content

Use non-deprecated wx GUI event loop - #2070

Open
nightcityblade wants to merge 1 commit into
microsoft:mainfrom
nightcityblade:fix/issue-1901
Open

Use non-deprecated wx GUI event loop#2070
nightcityblade wants to merge 1 commit into
microsoft:mainfrom
nightcityblade:fix/issue-1901

Conversation

@nightcityblade

Copy link
Copy Markdown

Fixes #1901

Summary

  • replace the deprecated wx.EventLoop class in all wx input-hook paths
  • use wx.GUIEventLoop as recommended by wxPython

Testing

  • PYTHONPATH=. python3 -m pytest -q tests/test_pydev_ipython_011.py (15 passed)
  • python3 -m ruff check src/debugpy/_vendored/pydevd/pydev_ipython/inputhookwx.py
  • python3 -m ruff format --check src/debugpy/_vendored/pydevd/pydev_ipython/inputhookwx.py
  • git diff --check

@nightcityblade
nightcityblade requested a review from a team as a code owner August 29, 2026 03:21
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@bschnurr

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

@bschnurr

Copy link
Copy Markdown
Member

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Result: could-not-verify

Summary: Verification could not start because no trusted sandbox image is configured for `microsoft/debugpy`. The PR adds no tests, and the cited 15-test IPython suite does not exercise the wx event-loop implementations. The behavior therefore remains unexecuted in this pass.

Test runs: 1 not run

  • ⚠️ Not run | Verification preflight and targeted test discovery | git status --short && git diff --name-status upstream/main...HEAD && git diff --unified=40 upstream/main...HEAD -- src\debugpy_vendored\pydevd\pydev_ipython\inputhookwx.py && git diff --name-only --diff-filter=A upstream/main...HEAD && rg -n "inputhook_wx|GUIEventLoop|EventLoopRunner|test_pydev_ipython_011" tests src\debugpy_vendored\pydevd --glob "*.py" && if defined AUTOMATION_SANDBOX_PROFILE (echo AUTOMATION_SANDBOX_PROFILE=%AUTOMATION_SANDBOX_PROFILE%) else (echo AUTOMATION_SANDBOX_PROFILE=)
⚠️ Verification preflight and targeted test discovery diagnostic output
Container verification could not start: no trusted sandbox image is configured for microsoft/debugpy, and local execution was not authorized.

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wx.EventLoop() deprecation warning

2 participants