[Android] Harden JNI resource ownership

[bmehta001]

Description

Harden normal Android JNI resource ownership and failure handling found during the repository-wide follow-up to #1523.

• Stop using JNI strings after acquisition fails, and stop common-context conversion immediately while a Java exception is pending.
• Pass UUID context as GUID_t; the previous code converted the UUID string but accidentally passed the Java jstring, selecting the boolean SetContext overload.
• Retain debug-event classes/listeners with checked global references, bound callback-local references, and attach/detach native callback threads correctly.
• Fix zero-based listener identities, reuse one callback when a Java listener observes multiple event types, and release global references after its final explicit removal.
• Keep Privacy Guard custom event-name storage alive for as long as any shared guard instance and avoid publishing partially initialized singleton state.

The listener changes follow the existing explicit lifecycle: callers remove debug listeners before closing their manager. This PR does not add support for concurrent or reentrant listener mutation.

Validation

• Built the Android arm64 native library with NDK 29 and MATSDK_WARNINGS_AS_ERRORS=ON, exempting only the pre-existing pessimizing-move, unused-variable, and sign-compare warning categories.
• Compiled the MAE SDK Java sources and Android instrumentation sources.
• Assembled the debug instrumentation APK and native libraries for arm64-v8a, armeabi-v7a, x86, and x86_64.
• Added instrumentation coverage for zero-based listener identity, callback reuse across event types, and identity release after final removal.

No Android device was connected, so the instrumentation APK was assembled but not executed.

[Copilot]

Pull request overview

This PR hardens Android JNI resource ownership and failure handling across the SDK’s JNI bridge, focusing on correct lifetime management (JNI references and borrowed string storage) and safer behavior when Java exceptions are pending.

Changes:

• Improves JNI string/array conversion paths to stop using results after conversion failures and to bail out when a Java exception is pending.
• Reworks Privacy Guard initialization to retain event-name storage for the lifetime of the native instance and to avoid exposing partially initialized singleton state.
• Strengthens debug-event listener lifecycle/identity handling, including listener reuse across event types and safer release behavior; adds/extends tests for snapshot semantics and identity reuse.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/unittests/DebugEventSourceTests.cpp	Adds a unit test validating listener snapshot behavior when listeners remove others during dispatch.
lib/jni/PrivacyGuard_jni.cpp	Makes PrivacyGuard initialization exception-safe and fixes lifetime of borrowed event-name strings via shared state + atomic load/store.
lib/jni/LogManager_jni.cpp	Hardens JNI string conversions and significantly reworks debug event listener registration/removal and callback lifetime management.
lib/jni/JniConvertors.cpp	Adds exception checks during JNI array-to-vector conversion to stop on failure and clean up local refs correctly.
lib/callbacks/DebugSourceInternal.hpp	Introduces internal API for tracking “pending” listeners during dispatch and a pending-release callback hook.
lib/callbacks/DebugSource.cpp	Implements pending-listener tracking to keep dispatch snapshots valid under re-entrant listener mutation.
lib/android_build/maesdk/src/main/java/com/microsoft/applications/events/LogManagerProvider.java	Updates native remove-listener API to return updated identity and pass the listener instance for validation.
lib/android_build/app/src/androidTest/java/com/microsoft/applications/events/maesdktest/LogManagerDDVUnitTest.java	Extends instrumentation coverage for listener identity reuse across event types and final identity release after removal.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

lib/jni/JniConvertors.cpp:212

• If GetObjectArrayElement triggers a Java exception, the code returns early without ensuring any non-null local ref returned by GetObjectArrayElement is released. This can leak a local reference in exceptional paths and contribute to LocalReferenceTable overflows in long-running JNI calls.

        auto jStringValue = static_cast<jstring>(env->GetObjectArrayElement(jArrayToConvert, i));
        if (env->ExceptionCheck())
        {
            return stringVector;
        }

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.