Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Fix LU parser rules to support all comments in a file - #6744

Merged
tracyboehrer (tracyboehrer) merged 3 commits into
mainfrom
southworks/fix/antlr-parser-issue
Feb 6, 2024
Merged

tracyboehrer (tracyboehrer) merged 3 commits into
mainfrom
southworks/fix/antlr-parser-issue

Conversation

@sw-joelmut

Copy link
Copy Markdown
Collaborator

#minor

Description

This PR updated the LU lexer and parser rules to support the case with a LU file with only comments in it.

Specific Changes

  • Updated LUFileParser.g4 and LuFileLexer.g4 files.
  • Autogenerated the ANTLR files after updating the rules.
  • Updated expected results in unit tests to match the changes.
  • Added a new unit test to cover the new scenario.

Testing

This image shows the unit tests passing after the changes.
image

@sw-joelmut
Joel Mut (sw-joelmut) requested a review from a team as a code owner February 6, 2024 13:14
@sw-joelmut Joel Mut (sw-joelmut) added the Automation: No parity PR does not need to be applied to other languages. label Feb 6, 2024
@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 384362

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 78.379%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 93.94%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 93.94%
Totals Coverage Status
Change from base Build 384324: 0.0%
Covered Lines: 26174
Relevant Lines: 33394

💛 - Coveralls

@tracyboehrer
tracyboehrer (tracyboehrer) deleted the southworks/fix/antlr-parser-issue branch February 6, 2024 14:58
tracyboehrer (tracyboehrer) pushed a commit that referenced this pull request Feb 6, 2024
* Update LU parser rules to support only comments

* Fix unit tests

* Add unit test to cover all comments case

---------

Co-authored-by: CeciliaAvila <cecilia.avila@southworks.com>
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants