Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

fix: USGovSingleTenant OAuthEndpoint - #6714

Merged
tracyboehrer (tracyboehrer) merged 5 commits into
microsoft:mainfrom
fangyangci:fixUSGovSingleTenant
Dec 19, 2023
Merged

tracyboehrer (tracyboehrer) merged 5 commits into
microsoft:mainfrom
fangyangci:fixUSGovSingleTenant

Conversation

@fangyangci

@fangyangci fangyangci commented Dec 13, 2023 •

Copy link
Copy Markdown
Contributor

Fixes #6717
JS PR #4588

Description

Fix a potential bug with USGov OAuthEndpoint while using SingleTenant.
Single tenant can't get token within <MicrosoftServices.onmicrosoft.us>.

Specific Changes

Update MicrosoftGovernmentAppCredentials.OAuthEndpoint.

Testing

Test locally, hard to add usgov single appid/password to the TestEnvironment.
MicrosoftGovernmentAppCredentialsTests.ConstructorTests

@fangyangci
fangyangci requested a review from a team as a code owner December 13, 2023 14:55
@fangyangci fangyangci changed the title fixUSGovSingleTenant FixUSGovSingleTenant OAuthEndpoint Dec 13, 2023
@fangyangci fangyangci changed the title FixUSGovSingleTenant OAuthEndpoint Fix USGovSingleTenant OAuthEndpoint Dec 13, 2023
@tracyboehrer tracyboehrer (tracyboehrer) added the Automation: No parity PR does not need to be applied to other languages. label Dec 14, 2023
@fangyangci fangyangci changed the title Fix USGovSingleTenant OAuthEndpoint fix: USGovSingleTenant OAuthEndpoint Dec 19, 2023
@tracyboehrer
tracyboehrer (tracyboehrer) merged commit 822ae31 into microsoft:main Dec 19, 2023
tracyboehrer (tracyboehrer) pushed a commit that referenced this pull request Jan 24, 2024
* fixUSGovSingleTenant

* Add UT

* Rollback AuthTenant Property Name

* The Ctor do contains the old ones, Add Ctor to ApiCompatBaseline
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

USGov OAuthEndpoint while using SingleTenant

2 participants