This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Repository navigation
Fix class structure for meeting notification feature extensibility - #6579
Merged
Merged
Conversation
yingduyingdu
force-pushed
the
yingdu/fixClass
branch
5 times, most recently
from
January 23, 2023 21:16
2779c8c to
6ab06ca
Compare
yingduyingdu
marked this pull request as ready for review
January 23, 2023 21:17
yingduyingdu
force-pushed
the
yingdu/fixClass
branch
from
January 24, 2023 00:49
6ab06ca to
605d6bd
Compare
Yunny Chung - MSFT (YunnyChung)
left a comment
Yunny Chung - MSFT (YunnyChung)
left a comment
There was a problem hiding this comment.
First PR review :)
Yunny Chung - MSFT (YunnyChung)
left a comment
Yunny Chung - MSFT (YunnyChung)
left a comment
There was a problem hiding this comment.
Additional comment for my own learning :)
yingduyingdu
force-pushed
the
yingdu/fixClass
branch
2 times, most recently
from
January 26, 2023 05:15
66bbed4 to
c7e4058
Compare
…s pass, manual tests pass
yingduyingdu
force-pushed
the
yingdu/fixClass
branch
from
January 26, 2023 05:25
c7e4058 to
e9fc060
Compare
vule-msft
suggested changes
Jan 27, 2023
Yunny Chung - MSFT (YunnyChung)
left a comment
Yunny Chung - MSFT (YunnyChung)
left a comment
There was a problem hiding this comment.
A few follow ups
yingduyingdu
force-pushed
the
yingdu/fixClass
branch
from
January 27, 2023 20:48
457649f to
4ddab23
Compare
yingduyingdu
requested review from
Yunny Chung - MSFT (YunnyChung),
Kavin (singhk97) and
vule-msft
and removed request for
Yunny Chung - MSFT (YunnyChung) and
vule-msft
January 30, 2023 21:14
This was referenced Aug 31, 2026
This was referenced Sep 9, 2026
This was referenced Sep 17, 2026
This was referenced Sep 24, 2026
This was referenced Oct 5, 2026
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6580
Description
This PR fixes the extensibility issue for the Teams bot meeting notification feature by updating on model classes.
Specific Changes
Update classes to support different types of meeting notification, surface type, and content type.
Update reference and unit tests.
Testing
Update and pass unit tests.
Pass manual testing via personal test bot.