Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Update ANTLR to 4.11.1 - #6557

Closed
Vuk Vasić (vasicvuk) wants to merge 1 commit into
microsoft:mainfrom
vasicvuk:main
Closed

Vuk Vasić (vasicvuk) wants to merge 1 commit into
microsoft:mainfrom
vasicvuk:main

Conversation

@vasicvuk

@vasicvuk Vuk Vasić (vasicvuk) commented Nov 18, 2022 •

Copy link
Copy Markdown

Fixes #6558

Fixes the issue of conflict with the libraries using newer ANTLR.

The issue on ANTLR 4:
antlr/antlr4#3963

Description

  • Generated ANTLR files based on 4.11.1 version.
  • Changed LGFileParser.g4 to stop getting errors for EOF while generating
  • Removed BOM from g4 files

@vasicvuk
Vuk Vasić (vasicvuk) requested a review from a team as a code owner November 18, 2022 11:57
@tracyboehrer tracyboehrer (tracyboehrer) added the Automation: No parity PR does not need to be applied to other languages. label Nov 18, 2022
@tracyboehrer

Copy link
Copy Markdown
Member

Vuk Vasić (@vasicvuk) There are quite a few unit test failures along the lines of:

Error Message: System.InvalidOperationException : Text 'No such template '__temp__7ada936af4354f4391f96d84e693b454'.' didn't match expected text: 'alphaEntity'
It would appear 4.11 is a breaking change in more way than one. When I free up some time, I can take a closer look. But if you switch to Release-Windows (it also reports the errors on our MacLinux pipeline) and run the unit tests locally you can see what's happening. There are several, but Microsoft.Bot.Builder.Dialogs.Adaptive.Tests will trigger the failures.

@vasicvuk

Copy link
Copy Markdown
Author

Hi tracyboehrer (@tracyboehrer), Thanks for the feedback. I tried running tests but I get a lot of issues that I don't understand. In general, we use the Adaptive Expressions library and test pass for it, so I published a modified version on the local NuGet feed as a workaround.

When you have time to look at it more closely I would be happy to help and finish the PR :)

@tracyboehrer

Copy link
Copy Markdown
Member

Vuk Vasić (@vasicvuk) Thank you for your input on this. We used this as the starting point for another PR: #6586, and will close this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages. BREAKING

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to ANTLR 4.11 to compensate for breaking changes between versions

2 participants