Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#6339] Mark deprecated channels as obsolete in Channels enum - #6343

Merged
Gabo Gilabert (gabog) merged 2 commits into
mainfrom
southworks/update/channel-constantes-cleanup-mark-obsolete-channels
May 31, 2022
Merged

Gabo Gilabert (gabog) merged 2 commits into
mainfrom
southworks/update/channel-constantes-cleanup-mark-obsolete-channels

Conversation

@ceciliaavila

@ceciliaavila Cecilia Avila (ceciliaavila) commented May 27, 2022 •

Copy link
Copy Markdown
Collaborator

Fixes #6339

Description

This PR marks the unsupported channels as deprecated.
Unsupported channels:

  • Cortana
  • EnterpriseChannel
  • Kaizala
  • Kik
  • SkypeForBusiness

Specific Changes

  • Unsupported channels are marked as deprecated in Microsoft.Bot.Connector/Channels.cs

Testing

This screenshot shows the unit tests passing
image

@ceciliaavila
Cecilia Avila (ceciliaavila) requested a review from a team as a code owner May 27, 2022 11:45
@ceciliaavila Cecilia Avila (ceciliaavila) added the Automation: No parity PR does not need to be applied to other languages. label May 27, 2022
@BruceHaley

Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

@coveralls

Coveralls (coveralls) commented May 27, 2022 •

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 306659

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 78.942%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
Totals Coverage Status
Change from base Build 305828: -0.003%
Covered Lines: 25372
Relevant Lines: 32140

💛 - Coveralls

@BruceHaley

Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

@gabog
Gabo Gilabert (gabog) merged commit 93ec5ea into main May 31, 2022
@gabog
Gabo Gilabert (gabog) deleted the southworks/update/channel-constantes-cleanup-mark-obsolete-channels branch May 31, 2022 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark deprecated channels as obsolete in Channels enum

4 participants