Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

fix: MeetingDetails dates are nullable - #6337

Merged
tracyboehrer (tracyboehrer) merged 1 commit into
mainfrom
eric/meetingDetailsNullableDates
Jul 5, 2022
Merged

fix: MeetingDetails dates are nullable#6337
tracyboehrer (tracyboehrer) merged 1 commit into
mainfrom
eric/meetingDetailsNullableDates

Conversation

@EricDahlvang

@EricDahlvang Eric Dahlvang (EricDahlvang) commented May 19, 2022

Copy link
Copy Markdown
Member

Fixes #6336

@EricDahlvang Eric Dahlvang (EricDahlvang) added the Automation: No parity PR does not need to be applied to other languages. label May 19, 2022
@EricDahlvang
Eric Dahlvang (EricDahlvang) requested a review from a team as a code owner May 19, 2022 18:14
@BruceHaley

BruceHaley commented May 19, 2022

Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@EricDahlvang Eric Dahlvang (EricDahlvang) added Automation: Parity with js The PR needs to be ported to JS and removed Automation: No parity PR does not need to be applied to other languages. labels May 19, 2022
@coveralls

Coveralls (coveralls) commented May 19, 2022

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 305177

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 78.945%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 3 89.62%
Totals Coverage Status
Change from base Build 304888: -0.003%
Covered Lines: 25373
Relevant Lines: 32140
💛 - Coveralls

@EricDahlvang Eric Dahlvang (EricDahlvang) added Automation: Parity all The PR needs to be ported to all repos (dotnet, JS, Python and Java) and removed Automation: Parity with js The PR needs to be ported to JS labels May 19, 2022
LeeParrishMSFT
Lee Parrish (LeeParrishMSFT) reviewed May 20, 2022
View reviewed changes
Comment thread libraries/Microsoft.Bot.Schema/Teams/MeetingDetails.cs
@EricDahlvang Eric Dahlvang (EricDahlvang) added this to the R17 milestone Jun 15, 2022
@tracyboehrer
tracyboehrer (tracyboehrer) deleted the eric/meetingDetailsNullableDates branch July 5, 2022 18:05
@github-actions github-actions Bot mentioned this pull request Jul 5, 2022
Closed
This was referenced Aug 31, 2026
Closed
Closed
Closed
Closed
This was referenced Sep 9, 2026
Closed
Closed
Closed
Closed
This was referenced Sep 17, 2026
Closed
Closed
Closed
This was referenced Sep 24, 2026
Closed
Closed
Closed
This was referenced Oct 5, 2026
Closed
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@johnataylor johnataylor johnataylor left review comments
@LeeParrishMSFT Lee Parrish (LeeParrishMSFT) LeeParrishMSFT left review comments
@tracyboehrer tracyboehrer (tracyboehrer) tracyboehrer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Automation: Parity all The PR needs to be ported to all repos (dotnet, JS, Python and Java) BREAKING

Projects

None yet

Milestone

R17

Development

Successfully merging this pull request may close these issues.

MeetingDetails ScheduledStartTime and ScheduledEndTime should be nullable

6 participants

@EricDahlvang @BruceHaley @coveralls @tracyboehrer @johnataylor @LeeParrishMSFT