Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#6292] Update Azure Queues from Functional to Unit tests - #6305

Merged
Gabo Gilabert (gabog) merged 3 commits into
mainfrom
southworks/update/azure-queues-tests
Jun 8, 2022
Merged

Gabo Gilabert (gabog) merged 3 commits into
mainfrom
southworks/update/azure-queues-tests

Conversation

@sw-joelmut

Copy link
Copy Markdown
Collaborator

Addresses #6292
#minor

Description

This PR removes the existing Functional tests and as a replacement, it adds support for internal testing to the AzureQueueStorage class, and introduces all the necessary unit tests, increasing the code coverage up to 100%.

Specific Changes

  • Updates the AzureQueueStorage class, adding a new internal constructor.
  • Adds new unit tests to the AzureQueueStorageTests class for each method, constructor, method validations, etc.

Testing

The following image shows the new unit tests and the code coverage.
image

@sw-joelmut Joel Mut (sw-joelmut) added the Automation: No parity PR does not need to be applied to other languages. label Apr 25, 2022
@sw-joelmut
Joel Mut (sw-joelmut) requested a review from a team as a code owner April 25, 2022 17:36
@coveralls

Coveralls (coveralls) commented Apr 25, 2022 •

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 304875

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 78.958%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/ForEachElement.cs 8 90.0%
/libraries/Microsoft.Bot.Builder/BotFrameworkAdapter.cs 17 47.91%
Totals Coverage Status
Change from base Build 301524: 0.3%
Covered Lines: 25377
Relevant Lines: 32140

💛 - Coveralls

@gabog
Gabo Gilabert (gabog) merged commit a4b3994 into main Jun 8, 2022
@gabog
Gabo Gilabert (gabog) deleted the southworks/update/azure-queues-tests branch June 8, 2022 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants