This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Repository navigation
Add support for search invoke - #6272
Merged
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 296646
💛 - Coveralls |
johnataylor
approved these changes
Mar 21, 2022
johnataylor
left a comment
Contributor
There was a problem hiding this comment.
The validate logic looks pretty watertight to me. Maybe an extra unit test to prevent someone accidentally regressing this in the future.
|
|
||
| if (string.IsNullOrEmpty(searchInvokeValue.QueryText)) | ||
| { | ||
| missingField = nameof(searchInvokeValue.QueryText); |
Contributor
There was a problem hiding this comment.
nit: isn't nameof going to give you the C# identifier whereas what you really want in the error message is the JSON property name. OK this is perhaps a nit because the only difference in this case at the current time is the casing.
I'm assuming the json property attribute doesn't override the nameof result (can you even do that?)
Gabo Gilabert (gabog)
approved these changes
Mar 21, 2022
This was referenced Aug 31, 2026
This was referenced Sep 9, 2026
This was referenced Sep 17, 2026
This was referenced Sep 24, 2026
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5643
OnInvokeActivityAsynchere:https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/main/samples/bot-type-ahead-search-adaptive-cards/csharp/TypeaheadSearch/Bots/ActivityBot.cs#L85
Would be changed to: