build: preserve GLIBC 2.28 compatibility - #389
Conversation
Pin the Copilot SDK and CLI versions so native pvrecorder binaries requiring newer GLIBC versions are not packaged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Regenerate both lockfiles so their root metadata records the package overrides and matches package.json.
Review effort: Lite
Findings: None
What changed in this PR
Pins Copilot dependencies to preserve GLIBC 2.28 compatibility and removes the incompatible native module.
Changes:
- Pins
@github/copilot-sdkto0.2.0. - Overrides
@github/copilotto1.0.10. - Updates CLI and extension dependency lockfiles.
| File | Summary |
|---|---|
vscode-extension/package.json |
Pins compatible Copilot dependencies. |
vscode-extension/package-lock.json |
Locks the compatible dependency tree; root override metadata is missing. |
package.json |
Pins compatible Copilot dependencies. |
package-lock.json |
Locks the compatible dependency tree; root override metadata is missing. |
Files not reviewed (1)
- vscode-extension/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Rechecked with npm 11.13.0: both lockfiles were regenerated after the 🤖 Posted by GitHub Copilot on Harald's behalf. |
Summary
@github/copilot-sdkto0.2.0in the CLI and VS Code extension@github/copilotto1.0.10in both dependency treespvrecordernative binary that requires GLIBC newer than 2.28Why
Azure CI build 476515 failed the native module compatibility check because Copilot
1.0.45bundled@picovoice/pvrecorder-node, whose Linux x64 binary depends on GLIBC > 2.28. The permissive SDK range allowed the root lockfile to drift to SDK0.2.2and Copilot1.0.45.Validation
npm ciin the root andvscode-extension0.2.0and Copilot1.0.10pvrecorderorpv_recorder.nodenpm run buildnpm run typecheckcd vscode-extension && node esbuild.mjs && npx tsc --noEmitgit diff --check🤖 Posted by GitHub Copilot on Harald's behalf.