Skip to content

.NET: tests(workflows): adds a regression test for cookie jar handling in redirection - #8427

Merged
Vincent Biret (baywet) merged 3 commits into
mainfrom
fix/cookie-jar
Sep 16, 2026
Merged

Vincent Biret (baywet) merged 3 commits into
mainfrom
fix/cookie-jar

Conversation

@baywet

Copy link
Copy Markdown
Member

adds a regression test for the cookie jar handling in redirections, the actual behaviour was fixed in #8164

Copilot AI balanced review requested due to automatic review settings September 16, 2026 12:10
@agent-framework-automation agent-framework-automation Bot added the .NET Usage: [Issues, PRs], Target: .Net label Sep 16, 2026
@github-actions github-actions Bot changed the title tests(workflows): adds a regression test for cookie jar handling in redirection .NET: tests(workflows): adds a regression test for cookie jar handling in redirection Sep 16, 2026

This comment was marked as outdated.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: No findings
Scope: full PR (1 commit(s)): c9dedc719553
Model: gpt-5.6-sol-fast

Overview

This test-only PR uses a loopback server and the real internally owned HttpClient to pin cookie isolation across successive requests. The production client explicitly disables cookies and automatic redirects, while existing redirect tests verify that request headers are not propagated to redirected endpoints. No new publishable Critical, High, or Medium finding remains after deduplication against existing feedback.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

@github-code-quality

github-code-quality Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall line coverage in commit 16e6867 in the fix/cookie-jar branch is 84%. Line coverage data for the main branch is not yet available.

Show a line coverage summary of the most covered files.
File main fix/cookie-jar 16e6867 +/-
/home/runner/wo...valConverter.cs 100%
/home/runner/wo...entsProvider.cs 99%
/home/runner/wo...nticAnalyzer.cs 94%
/home/runner/wo...tClientAgent.cs 91%
/home/runner/wo...putConverter.cs 90%
/home/runner/wo...kflowBuilder.cs 90%
/home/runner/wo...kflowSession.cs 87%
/home/runner/wo...SkillsSource.cs 86%
/home/runner/wo...onExtensions.cs 81%
/home/runner/wo...ctionVisitor.cs 70%

Updated September 16, 2026 12:38 UTC

This comment was marked as outdated.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The tests accurately cover the cookie-handling behavior fixed by PR #8164.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@baywet
Vincent Biret (baywet) marked this pull request as ready for review September 16, 2026 12:54

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 2

Result: No findings
Scope: 2 net-new commit(s): 446b9f9e05a2, 16e68678aa4b
Model: gpt-5.6-sol-fast

Overview

This incremental update adds a focused regression test that drives a real 307 redirect carrying Set-Cookie through a single SendAsync call. The fixture verifies request order, response behavior, and explicit cookie absence, while the production owned client disables cookie handling and automatic redirects. No publishable Critical, High, or Medium concern remains.

Reviewed the supplied incremental change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

@baywet
Vincent Biret (baywet) added this pull request to the merge queue Sep 16, 2026
Merged via the queue into main with commit c97528b Sep 16, 2026
37 checks passed
@baywet
Vincent Biret (baywet) deleted the fix/cookie-jar branch September 17, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants