Update of glob-style pattern matching - #8841
Conversation
Conflicts: Jakefile.js src/compiler/commandLineParser.ts src/compiler/core.ts src/compiler/sys.ts src/harness/harness.ts src/server/editorServices.ts src/services/shims.ts tests/cases/unittests/cachingInServerLSHost.ts
Conflicts: src/compiler/sys.ts src/harness/harnessLanguageService.ts tests/cases/unittests/cachingInServerLSHost.ts tests/cases/unittests/tsconfigParsing.ts
|
Hi Richard Knoll (@riknoll), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
Ron Buckton (@rbuckton) could you take a look when you have a moment? |
| continue; | ||
| } | ||
|
|
||
| if (IgnoreFileNamePattern.test(file)) { |
There was a problem hiding this comment.
nit: capitalization - ignoreFileNamePattern
|
Ron Buckton (@rbuckton) thanks! |
|
wow 🎉 🌹 |
|
//CC: Basarat Ali Syed (@basarat), Johannes Rieken (@jrieken), Blake Embrey (@blakeembrey) James Brantly (@jbrantly), Adi Dahiya (@adidahiya), Alex Eagle (@alexeagle), martine this change has a breaking change to the public API, changing the arguments to readDirectory(rootDir: string, extension: string, exclude: string[]): string[];to: readDirectory(rootDir: string, extensions: string[], excludes: string[], includes: string[]): string[];Please do let us know if this is something that manageable on your side or more changes needs to be done on the TS side. |
Mohamed Hegazy (mhegazy)
added
the
Breaking Change
Mohamed Hegazy (mhegazy)
added
the
Domain: API
|
Awesome!😃 |
|
Mohamed Hegazy (@mhegazy) thanks for thinking of me! I didn't see any use/impl of readDirectory in Google code. In Angular2 I found one use Alex Eagle (@alexeagle) , but it's likely easy to update: In general I think we (Google) don't mind too much when you change APIs, especially when it's a small change that the compiler can easily spot when we update. And usually the only reason to change an API in a large way is because it's important so we'll likely be able to make that work as well. |
|
thanks martine for getting to us back on this. |
This is required due to breaking change in TS, see microsoft/TypeScript#8841 (comment)
This is required due to breaking change in TS, see microsoft/TypeScript#8841 (comment)
|
I'm having trouble excluding arbitrarily deep |
they might still get pulled in because of |
|
|
9 participants
This is a resubmission of #5980 that has been brought up to date with master (the old PR had a lot of non-trivial merge conflicts with the current master). The behavior differs somewhat from the specification in #5980 to better reflect the current behavior of the compiler. Excluded patterns now default to the common package directories (
node_modules,bower_components, etc.) when "exclude" is not found intsconfig.json. Additionally, the out directory is always excluded unless explicitly included in "files".Mohamed Hegazy (@mhegazy) Ron Buckton (@rbuckton) Bill Ticehurst (@billti) please take a look when you have a moment!