DOM Update 2025-05-02 - #61647
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the DOM types to incorporate changes from the referenced TypeScript-DOM-lib-generator pull request, while ensuring that related error messages and contextual type instantiations continue to behave as expected.
- Updates baseline errors for instantiateContextualTypes tests
- Covers new contextual typing scenarios with generic components and reducer patterns
Files not reviewed (6)
- tests/baselines/reference/collisionThisExpressionAndLocalVarInLambda.types: Language not supported
- tests/baselines/reference/globalThisBlockscopedProperties.types: Language not supported
- tests/baselines/reference/instantiateContextualTypes.types: Language not supported
- tests/baselines/reference/noCollisionThisExpressionAndLocalVarInLambda.types: Language not supported
- tests/baselines/reference/underscoreTest1.types: Language not supported
- tests/baselines/reference/unicodeIdentifierName2.types: Language not supported
|
TypeScript Bot (@typescript-bot) test this |
|
Hey Ron Buckton (@rbuckton), the results of running the DT tests are ready. There were interesting changes: Branch only errors:Package: jquery.fancytree Package: w3c-image-capture Package: summernote Package: node Package: ckeditor4 Package: dropboxjs Package: microsoft-ajax Package: photoswipe Package: hashset Package: codemirror Package: signals Package: chrome Package: react-swipe Package: snapsvg Package: jquery/v1 Package: jquery/v2 Package: jquery Package: jquery-touchswipe Package: phonegap Package: three Package: less Package: lscache Package: switchery |
|
Ron Buckton (@rbuckton) Here are the results of running the user tests with tsc comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
|
Ron Buckton (@rbuckton) Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
A large number of failures seem to be due to the signature of |
|
Ron Buckton (@rbuckton) Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
FYI Kagami Sascha Rosylight (@saschanaz) Adam Naji (@Bashamega) |
|
Starting jobs; this comment will be updated as builds start and complete.
|
Any idea what the failure looks like? |
|
Err, okay, |
|
|
|
Actually I'm talking about https://github.com/microsoft/TypeScript/actions/runs/14803024546/job/41565917783?pr=61647, but that's just an internal test? |
|
Hey Ron Buckton (@rbuckton), the results of running the DT tests are ready. There were interesting changes: Branch only errors:Package: w3c-image-capture Package: node Package: three |
Nathan Shively-Sanders (sandersn)
left a comment
There was a problem hiding this comment.
Besides ArrayBufferLike, it's almost all additions. Plus tonnes of comment changes.
|
|
|
Ah, the "is not assignable to parameter of type 'string'" errors. Err, still looks like something TS test specific, but perhaps also maybe an early smoke of something bigger. I'm open to backout. |
There are similar errors in the user tests, though not as frequent. |
|
TypeScript Bot (@typescript-bot) run dt |
|
Ron Buckton (@rbuckton) Here are the results of running the user tests with tsc comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
|
Hey Ron Buckton (@rbuckton), the results of running the DT tests are ready. Everything looks the same! |
|
Ron Buckton (@rbuckton) Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
|
TypeScript Bot (@typescript-bot): pack this |
|
The bot is broken, I am fixing it. (your command also has a colon after the username which probably wouldn't work) |
I have that as a "Saved Reply" on GitHub. It's always worked in the past. |
|
The errors in |
Oh right, I forgot I made that work in microsoft/typescript-bot-test-triggerer@bb85856 |
|
I've also put a PR up for VSCode here: microsoft/vscode#248346 |
|
Should we revert that |
No, the revert we made here was also made to TypeScript-DOM-lib-generator: microsoft/TypeScript-DOM-lib-generator#2015 |
|
Ah, great; I just hadn't gotten that far into my inbox. |
This updates the DOM types to include changes from microsoft/TypeScript-DOM-lib-generator#1944, among others.
Fixes #61480